Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10618 - CowonD2 EQ Menu Buttons

Attached to Project: Rockbox
Opened by Carsten Schreiter (Kuma76) - Friday, 25 September 2009, 17:34 GMT+2
Last edited by Rob Purchase (shotofadds) - Sunday, 11 October 2009, 17:29 GMT+2
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Player Type Another
Severity Low
Priority Normal
Reported Version Release 3.4
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch changes the button assignment in the graphical EQ menu on a Cowon D2 like below and makes the EQ menu easier to use (of course in the 3x3 grid mode only).

TOP_MIDDLE, MIDDLE_RIGHT, BOTTOM_MIDDLE, MIDDLE_LEFT are to navigate through the EQ settings.

BOTTOM_LEFT and BOTTOM_RIGHT are to change settings (in that way the setting is visible when changing it)

TOP_LEFT is to leave the EQ menu.
   cowonD2_EQ menu buttons.patch (2.6 KiB) 
 apps/action.h                     |    8 +++++++-
 apps/menus/eq_menu.c              |   21 +++++++++++++++++++++
 apps/keymaps/keymap-touchscreen.c |   10 ++++++++++
 3 files changed, 38 insertions(+), 1 deletion(-)

This task depends upon

Closed by  Rob Purchase (shotofadds)
Sunday, 11 October 2009, 17:29 GMT+2
Reason for closing:  Out of Date
Additional comments about closing:  Part committed, part superceded by 10639
Comment by Thomas Martitz (kugel.) - Friday, 25 September 2009, 19:37 GMT+2
Can you instead fix the eq screen to work with the touchscreen mode? We're not really happy about the grid mode at all and rather see that removed in the long tern,
Comment by Rob Purchase (shotofadds) - Saturday, 26 September 2009, 13:25 GMT+2
I had a look into this last night, thinking there must be a much simpler way to get this working than introducing a load of #ifdef's. It turns out all the problems with the EQ screen were due to conflicts (duplicated mappings) in the existing touchscreen keymap.

The following patch makes it work properly using the existing controls (up, down, left, right, centre to change mode). I think it's somewhat cleaner.

(ps. kugel is right, this screen really needs some re-work for the "real" touchscreen mode - so I'll leave this task open after I commit the above)

EDIT: I removed too much, patch updated ;-)
   eq.diff (1.7 KiB) 
 apps/keymaps/keymap-touchscreen.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Loading...