Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10648 - Cowon D2: Mpegplayer control using hardware buttons and Hold switch

Attached to Project: Rockbox
Opened by Arago (Arago) - Sunday, 04 October 2009, 23:08 GMT+2
Task Type Patches
Category User Interface
Status Unconfirmed
Assigned To No-one
Player Type Another
Severity Low
Priority Normal
Reported Version Release 3.4
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Private No

Details

Added seeking by holdplus/holdminus buttons, pause/play by holdmenu button, hiding the OSD panel by briefly pressing power switch.
   mpegplayer.patch (0.9 KiB) 
 apps/plugins/mpegplayer/mpegplayer.c |   12 ++++++++++++
 1 file changed, 12 insertions(+)

Comment by Arago (Arago) - Sunday, 04 October 2009, 23:12 GMT+2
Sorry, I fogot:

Requires functionality of the buttons in the Hold mode patch by andrewthecoder (I can't post it here, because this code is not mine, but you can take it with any config on http://iaudiophile.net/forums/showthread.php?t=28467 or on http://uploads.arago.shell.tor.hu/rockbox/hold_buttons_patch.patch)
Comment by Arago (Arago) - Thursday, 25 February 2010, 18:43 GMT+2
I can make temporary (simplified, limited) version that will not require FS#10698. Should I do this?
Comment by Tomer Shalev (tomers) - Friday, 26 February 2010, 09:10 GMT+2
> I can make temporary (simplified, limited) version that will not require FS#10698. Should I do this?
If you mean the you can merge together FS#10698 and this patch, then this is not necessary, as FS#10698 requires a discussion, and this patch can not be committed without FS#10698 being committed first.

Could you please have a separate patch with merely the new feature of hiding the OSD panel by briefly pressing power switch? This could be committed regardless of FS#10698.
Comment by Arago (Arago) - Friday, 26 February 2010, 14:51 GMT+2
No, of course I can't mix my code and FS#10698.
I can try to create mapping without hold buttons, just short and long keypresses in normal mode.
Here is patch for hiding OSD.
   mpegplayer_wvs_hide.patch (0.8 KiB) 
 apps/plugins/mpegplayer/mpegplayer.c |   10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

Loading...