Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10649 - Calendar plugin - Add US display style and selection menu

Attached to Project: Rockbox
Opened by Michael Chicoine (mc2739) - Monday, 05 October 2009, 00:04 GMT+2
Last edited by Teruaki Kawashima (teru) - Wednesday, 04 November 2009, 14:09 GMT+2
Task Type Patches
Category Plugins
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch adds an item to the calendar menu to allow switching the display style between the default European style (first day of week is Monday) and the US style (first day of week is Sunday).

Manual patch is also included.
   calendar.patch (5.6 KiB) 
 apps/plugins/calendar.c |   75 +++++++++++++++++++++++++++++++++++++++---------
 1 file changed, 62 insertions(+), 13 deletions(-)

   calendar-manual.patch (0.7 KiB) 
 manual/plugins/calendar.tex |    7 +++++++
 1 file changed, 7 insertions(+)

This task depends upon

Closed by  Teruaki Kawashima (teru)
Wednesday, 04 November 2009, 14:09 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Committed in r23516
Comment by Teruaki Kawashima (teru) - Monday, 05 October 2009, 16:39 GMT+2
Your patch looks incorrect and complicated unnecessarily for me.
As far as i looked at the patch, weekday of weekly events would differ depending on Calendar Mode setting.

This patch is what I thought it should be like.
   calendar_wday_style.patch (4.7 KiB) 
 apps/plugins/calendar.c |   56 +++++++++++++++++++++++++++++++++++++++---------
 1 file changed, 46 insertions(+), 10 deletions(-)

Comment by Michael Chicoine (mc2739) - Tuesday, 06 October 2009, 03:54 GMT+2
You are correct, I did not see that problem. Thank you for taking the time to put together a patch that works properly.
Comment by Teruaki Kawashima (teru) - Wednesday, 21 October 2009, 15:35 GMT+2
this patch allows to choose first day of week from Mon, Tue, ..., Sun.
   calendar_wday_start.patch (4.2 KiB) 
 apps/plugins/calendar.c |   50 ++++++++++++++++++++++++++++++++++++++++++------
 1 file changed, 44 insertions(+), 6 deletions(-)

Loading...