Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10688 - Cowon D2 - Hold Menu button to easily return to WPS

Attached to Project: Rockbox
Opened by Brian DIll (bkd11) - Monday, 19 October 2009, 00:03 GMT+2
Last edited by Rob Purchase (shotofadds) - Thursday, 12 November 2009, 00:20 GMT+2
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Player Type Another
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Here's a simple patch that allows quickly returning to the WPS by holding the menu button.
This patch was made from r23249.
   keymap-cowond2.patch (0.5 KiB) 
 apps/keymaps/keymap-cowond2.c |    3 +++
 1 file changed, 3 insertions(+)

This task depends upon

Closed by  Rob Purchase (shotofadds)
Thursday, 12 November 2009, 00:20 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  The final patch was committed as r23616
Comment by Rob Purchase (shotofadds) - Monday, 19 October 2009, 00:41 GMT+2
It's a good idea to have a 'go to WPS' shortcut like this, but a long press of MENU is currently used in most places to open the context menu - and I think that behaviour should stay.

If you can find another key combination that works (eg. MENU + PLUS or something?) I'd consider including that in the build, but I can't include this as it stands.
Comment by Brian DIll (bkd11) - Monday, 19 October 2009, 01:47 GMT+2
Sorry, I forgot about the context menu. That definitely needs to stay. It's too bad the d2 only has three buttons to work with.

I tried what you suggested and it seemed to work ok. I was also thinking maybe to add (MENU + MINUS) also so it would make it easier to do blind. Here is both so you can decide which is best.
   keymap-cowond2.patch (0.5 KiB) 
 apps/keymaps/keymap-cowond2.c |    3 +++
 1 file changed, 3 insertions(+)

   keymap-cowond2(2).patch (0.5 KiB) 
 apps/keymaps/keymap-cowond2.c |    4 ++++
 1 file changed, 4 insertions(+)

Comment by Rob Purchase (shotofadds) - Thursday, 05 November 2009, 18:07 GMT+2
I was thinking about this again today, and I think the D2's physical buttons are a little too close together to make comfortable physical combo's (even for me, and I've got small fingers!). About the only combination that's comfortable and easy to use is PLUS + MINUS - so I propose to use that instead...
Comment by Brian DIll (bkd11) - Thursday, 05 November 2009, 20:25 GMT+2
That makes sense but would require using two fingers. The way I've been doing it with the above patches is by pushing both buttons with the same finger. MENU + PLUS if using my right index finger, and MENU + MINUS if using my left. Couldn't we just use all three methods? (PLUS + MINUS), (MENU + MINUS), (MENU + PLUS) That way people can choose which is most comfortable to them.
Comment by Rob Purchase (shotofadds) - Saturday, 07 November 2009, 19:57 GMT+2
Oh, I see what you mean with one finger. That works too ;-)

I don't really like the idea of having more than one button combination for the same thing (what happens if we find something else that needs to go on a button, there'll be no combinations left....) so we should decide on one and stick to it. Having tried them all out a few times I think I prefer MENU + PLUS.

If you had to choose one, which would it be?
Comment by Brian DIll (bkd11) - Monday, 09 November 2009, 04:39 GMT+2
MENU + PLUS works good for me.
Comment by Rob Purchase (shotofadds) - Tuesday, 10 November 2009, 00:41 GMT+2
One more revision ;-)

I changed it so that the combo is triggered by holding PLUS first, then MENU (similar to pressing CTRL + <key> on a PC). I found this works better, as you no longer end up entering the context menu by mistake if you hold MENU too long. It's still usable with one finger too.
   keymap-cowond2.patch (0.5 KiB) 
 apps/keymaps/keymap-cowond2.c |    2 ++
 1 file changed, 2 insertions(+)

Loading...