Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10785 - separate keymap for morse code input from keymap for keyboard

Attached to Project: Rockbox
Opened by Teruaki Kawashima (teru) - Sunday, 15 November 2009, 13:40 GMT+1
Last edited by Teruaki Kawashima (teru) - Saturday, 16 January 2010, 15:00 GMT+1
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.4
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

this patch adds new context, CONTEXT_MORSE_INPUT for keymaps and use it but CONTEXT_KEYBOARD while in morse code input mode in keyboard.
it's purpose is to make it easier/possible to adapt more keymaps for morse input.
but i'm not sure if this is a way to go. doesn't this make things complicated?
   keymap-morseinput.patch (35.8 KiB) 
 apps/action.h                     |    1 
 apps/recorder/keyboard.c          |   30 +++++++++++++----------
 apps/keymaps/keymap-h1x0_h3x0.c   |   48 +++++++++++++++++++++++++++++++++++---
 apps/keymaps/keymap-creativezv.c  |   14 ++++++++++-
 apps/keymaps/keymap-creativezvm.c |   15 +++++++++++
 apps/keymaps/keymap-gigabeat-s.c  |   15 +++++++++++
 apps/keymaps/keymap-gigabeat.c    |   14 ++++++++++-
 apps/keymaps/keymap-recorder.c    |   14 ++++++++++-
 apps/keymaps/keymap-e200.c        |   14 ++++++++++-
 apps/keymaps/keymap-m200.c        |   14 ++++++++++-
 apps/keymaps/keymap-sa9200.c      |   18 ++++++++++++--
 apps/keymaps/keymap-h10.c         |   14 ++++++++++-
 apps/keymaps/keymap-ipod.c        |   14 ++++++++++-
 apps/keymaps/keymap-x5.c          |   14 ++++++++++-
 apps/keymaps/keymap-mr100.c       |   14 ++++++++++-
 apps/keymaps/keymap-mr500.c       |   14 ++++++++++-
 apps/keymaps/keymap-meizu-m6sl.c  |   13 +++++++++-
 apps/keymaps/keymap-fuze.c        |   14 ++++++++++-
 apps/keymaps/keymap-hdd1630.c     |   14 ++++++++++-
 19 files changed, 275 insertions(+), 33 deletions(-)

This task depends upon

Closed by  Teruaki Kawashima (teru)
Saturday, 16 January 2010, 15:00 GMT+1
Reason for closing:  Accepted
Additional comments about closing:  Committed in r24250.
Comment by Teruaki Kawashima (teru) - Saturday, 09 January 2010, 13:40 GMT+1
* Simplify change - use same keymap for both CONTEXT_KEYBOARD and CONTEXT_MORSE_INPUT if possible.
* Enable morse input on ondio as an example.
   keymap-morseinput.2.patch (13.4 KiB) 
 apps/action.h                          |    1 +
 apps/recorder/keyboard.c               |    6 +++++-
 apps/keymaps/keymap-h1x0_h3x0.c        |    2 ++
 apps/keymaps/keymap-creativezv.c       |    1 +
 apps/keymaps/keymap-creativezvm.c      |    1 +
 apps/keymaps/keymap-gigabeat-s.c       |    2 ++
 apps/keymaps/keymap-gigabeat.c         |    1 +
 apps/keymaps/keymap-recorder.c         |    1 +
 apps/keymaps/keymap-e200.c             |    1 +
 apps/keymaps/keymap-hdd6330.c          |    1 +
 apps/keymaps/keymap-sa9200.c           |    4 +++-
 apps/keymaps/keymap-m200.c             |    1 +
 apps/keymaps/keymap-h10.c              |    1 +
 apps/keymaps/keymap-ipod.c             |    1 +
 apps/keymaps/keymap-x5.c               |    3 ++-
 apps/keymaps/keymap-mr100.c            |    1 +
 apps/keymaps/keymap-mr500.c            |    1 +
 apps/keymaps/keymap-meizu-m6sl.c       |    1 +
 apps/keymaps/keymap-ondio.c            |   18 ++++++++++++++++++
 apps/keymaps/keymap-fuze.c             |    1 +
 apps/keymaps/keymap-hdd1630.c          |    1 +
 firmware/export/config/archosondiofm.h |    3 +++
 firmware/export/config/archosondiosp.h |    3 +++
 manual/platform/keymap-archosondio.tex |    1 +
 24 files changed, 54 insertions(+), 3 deletions(-)

Loading...