Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10794 - .[r]sbs support for the theme site

Attached to Project: Rockbox
Opened by Dominik Wenger (Domonoky) - Wednesday, 18 November 2009, 23:16 GMT+2
Last edited by Dominik Wenger (Domonoky) - Wednesday, 02 December 2009, 21:29 GMT+2
Task Type Patches
Category Themes
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.4
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This is a patch to add .[r]sbs file checking into the theme site.

Unfortnuatly i couldnt test this at moment. Maybe someone else can test this ?
   sbs.patch (2.7 KiB) 
 private/themesite.class.php |   20 +++++++++++++++++---
 1 file changed, 17 insertions(+), 3 deletions(-)

This task depends upon

Closed by  Dominik Wenger (Domonoky)
Wednesday, 02 December 2009, 21:29 GMT+2
Reason for closing:  Accepted
Comment by Dominik Wenger (Domonoky) - Wednesday, 18 November 2009, 23:38 GMT+2
fix sps -> sbs typos.
   sbs.patch (2.7 KiB) 
 private/themesite.class.php |   20 +++++++++++++++++---
 1 file changed, 17 insertions(+), 3 deletions(-)

Comment by Maurus Cuelenaere (mcuelenaere) - Thursday, 19 November 2009, 08:59 GMT+2
This looks OK, does it also run it through checkwps? (not sure if that one can check sbs'es (yet))
Comment by Thomas Martitz (kugel.) - Thursday, 19 November 2009, 18:21 GMT+2
the 3rd hunk looks wrong to me

I think checkwps can't check sbs yet, because it has hardcoded the extensions (wps, rwps).
Comment by Dominik Wenger (Domonoky) - Thursday, 19 November 2009, 18:51 GMT+2
Fix the error Kugel spottet.

And yes, this runs the sbs/rsbs files through checkwps. According to JdGordon checkwps should be able to cope with sbs file.

This still needs testing on some webserver to make sure it actually works :-)
   sbs.patch (2.7 KiB) 
 private/themesite.class.php |   20 +++++++++++++++++---
 1 file changed, 17 insertions(+), 3 deletions(-)

Comment by Jonathan Gordon (jdgordon) - Thursday, 19 November 2009, 19:07 GMT+2
just qualidfy that 2nd sentance.... There is no difference (that i can immediatly think of) between .sbs and .wps apart from its extension... so it would surprise me if checkwps couldnt handle it...
Comment by Thomas Martitz (kugel.) - Thursday, 19 November 2009, 19:40 GMT+2
I also meant to mean that the hardcoded extensions is the only thing that needs to be fixed to make it parse sbs files :)
Comment by Maurus Cuelenaere (mcuelenaere) - Thursday, 19 November 2009, 20:15 GMT+2
You seem to add the filename to $rspsfound, but then check $rsbsfound.
Comment by Dominik Wenger (Domonoky) - Thursday, 19 November 2009, 21:04 GMT+2
ups. Fix typo
   sbs.patch (2.7 KiB) 
 private/themesite.class.php |   20 +++++++++++++++++---
 1 file changed, 17 insertions(+), 3 deletions(-)

Comment by Dominik Wenger (Domonoky) - Wednesday, 02 December 2009, 20:55 GMT+2
Finally i was able to test this. And it works ! :-)

Loading...