Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10801 - Enable strict aliasing compiler optimizations for codecs

Attached to Project: Rockbox
Opened by Nils Wallménius (nls) - Sunday, 22 November 2009, 10:40 GMT+2
Last edited by Nils Wallménius (nls) - Sunday, 29 November 2009, 19:14 GMT+2
Task Type Patches
Category Codecs
Status Closed
Assigned To No-one
Player Type SW-codec
Severity Low
Priority Normal
Reported Version Release 3.4
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Strict aliasing optimizations are disabled in svn because they were deemed to give too many warnings with gcc4.0, now that we are switching to 4.4 for arm some testing showed a few speedups on the beast with these optimizations enabled again so this patch fixes aliasing warnings in the codecs and turns on these optimizations for the codecs again.

the changes to mod are very simple, mp3_enc was also pretty simple but the spc changes were a little more invasive, so i'd like some more eyes on those before a commit.
   codec_strict_aliasing2.diff (6.9 KiB) 
 apps/codecs/mp3_enc.c          |   18 ++++++++++--------
 apps/codecs/codecs.make        |    4 ++--
 apps/codecs/mod.c              |    8 ++++----
 apps/codecs/libspc/spc_codec.h |   20 +++++++++++---------
 apps/codecs/libspc/spc_dsp.c   |   19 ++++++++++---------
 5 files changed, 37 insertions(+), 32 deletions(-)

This task depends upon

Closed by  Nils Wallménius (nls)
Sunday, 29 November 2009, 19:14 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  committed

Loading...