Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10811 - USEC_TIMER fix for nano 2G

Attached to Project: Rockbox
Opened by Laurent Papier (papier) - Wednesday, 25 November 2009, 19:21 GMT+2
Last edited by Michael Chicoine (mc2739) - Wednesday, 02 December 2009, 00:27 GMT+2
Task Type Patches
Category Operating System/Drivers
Status Closed
Assigned To No-one
Player Type iPod Nano 2G
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

The USEC_TIMER does not work on nano 2G.

For the user, this makes the clickwheel 'jumpy'.

TheSeven said : "the nano2g usec timer is actually a 64bit 5usec timer. rockbox only uses the lower 32 bits, but these only seem to get updated when the high part is read."

This patch also enable WHEEL_ACCEL as it seems to work fine.

Note: the macro is a little ugly but the operation (a>>31)&1 is not optimize by gcc. So we read the 64bits and only use the lower 32 bits.

   usec_timer.patch (1.5 KiB) 
 firmware/export/s5l8700.h           |    2 +-
 firmware/export/config-ipodnano2g.h |    6 ++++++
 2 files changed, 7 insertions(+), 1 deletion(-)

This task depends upon

Closed by  Michael Chicoine (mc2739)
Wednesday, 02 December 2009, 00:27 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Committed in r23747, r23748 and r23749

Loading...