Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10833 - Protect against division by zero in AAC (mp4) codec

Attached to Project: Rockbox
Opened by Juliusz Chroboczek (jch) - Saturday, 05 December 2009, 19:52 GMT+2
Last edited by MichaelGiacomelli (saratoga) - Monday, 14 December 2009, 02:09 GMT+2
Task Type Bugs
Category Battery/Charging
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.4
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This avoids a crash in the AAC codec. It's probably only fixing a symptom, not the actual bug, but it shouldn't do much harm not to crash in any case.

   0001-Protect-against-a-division-by-zero-in-aac-co... (0.9 KiB) 
 b/apps/codecs/libm4a/m4a.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

This task depends upon

Closed by  MichaelGiacomelli (saratoga)
Monday, 14 December 2009, 02:09 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Accepted in r23983.
Comment by Juliusz Chroboczek (jch) - Saturday, 05 December 2009, 20:24 GMT+2
This is triggered by  FS#10832 .
Comment by Juliusz Chroboczek (jch) - Sunday, 06 December 2009, 00:40 GMT+2
In addition, it turns out that libfaad sometimes returns NULL without setting frame_info.error, which causes us to play garbage or crash. Check for this case.
   0001-Protect-against-libfaad-returning-NULL.patch (1.4 KiB) 
 b/apps/codecs/aac.c |   10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

Loading...