This is the bug/patch tracker for Rockbox. Click here for more information.
Quick links: Bugs · Patches · Rockbox frontpage
FS#10853 - radio screen skin support
Attached to Project:
Rockbox
Opened by Jonathan Gordon (jdgordon) - Monday, 14 December 2009, 08:51 GMT+2
Last edited by Jonathan Gordon (jdgordon) - Wednesday, 12 May 2010, 12:38 GMT+2
Opened by Jonathan Gordon (jdgordon) - Monday, 14 December 2009, 08:51 GMT+2
Last edited by Jonathan Gordon (jdgordon) - Wednesday, 12 May 2010, 12:38 GMT+2
|
DetailsFull skin support for thr radio screen!
new tokens: (token letters can be changed if someone comes up with a better idea) tuner present: %tp tuner "tuned": %tt scan mode: %tm<scan|preset> minimum frequency: %ta maximum frequency: %tb current frequency: %tf preset number: %TiX (where X is a number, 0 is current, -1 is previous preset, 1 is next... numbers have no limits but must be there!) preset name %TnX preset freq: %TfX preset count: %Tc (i.e number of presets) target has RDS support: %tx RDS name: %ty RDS text: %tz and new recording tags for HWCODEC which records from inside the fm screen %Rr - is actually recording? (play status will be showing fm always so this is needed) %Rs - seconds recorded %Rn - minutes recorded %Rh - hours recorded. To load a skin add the usual skin line to your .cfg "fms: /.rockbox/wps/name.fms" 
radio_skin.patch
(20.8 KiB)
apps/recorder/radio.c | 204 +++++++++++++++---------------------- apps/recorder/radio.h | 8 + apps/lang/english.lang | 4 apps/settings.c | 27 ++++ apps/gui/skin_engine/wps_debug.c | 1 apps/gui/skin_engine/skin_parser.c | 35 ++++++ apps/gui/skin_engine/skin_tokens.c | 77 +++++++++++++ apps/gui/skin_engine/skin_tokens.h | 24 ++++ apps/settings.h | 4 apps/settings_list.c | 7 + 10 files changed, 270 insertions(+), 121 deletions(-) |
This task depends upon
Closed by Jonathan Gordon (jdgordon)
Wednesday, 12 May 2010, 12:38 GMT+2
Reason for closing: Accepted
Additional comments about closing: finally in svn! r25964
Wednesday, 12 May 2010, 12:38 GMT+2
Reason for closing: Accepted
Additional comments about closing: finally in svn! r25964
Can we used some frequency scale for the radio? Even a progress bar that ranges from minimum to maximum frequency will do.
%pb (progressbar) is now working.
someone with a archos recorderFM needs to test this patch. This is I tihnk ready for commit
a) In preset mode if you skip through presets using left/right then the preset name %TnX doesn't update - but if you select the preset from the list then it works fine
b) In scan mode, the frequency doesn't show properly. If the current frequency is the same as a preset it shows that, but if not it shows 106.6
c) When you switch between preset and scan mode then whilst the mode switches, %tm doesn't update until you leave the screen and come back e.g. go to the menu and back
The fms/sbs I'm using is attached.
a) is real however
Would it be possible to display the current frequency using custom bitmap numbers? Perhaps tokenizing each digit of the current frequency and using a bitmap strip with the digits 0-9 and a decimal point. That would allow for a prominent frequency display (similar to most OF radio screens) without using multi-font to get larger digits. It would look good on large displays where the FM screen is mostly empty.
I thought that with the skin engine this would be easy (although I don't really know how the skin engine works). Wouldn't it just be 6 extra tokens (xxx.xx). I assume the bitmap loading and display is already in the engine. The bitmap strip would need digits 0-9, a decimal, and a black space (for the leading digit for frequency < 100). If it uses the skin buffer, there's no real additional cost.
Maybe I'm just misunderstanding how the skin engine & tokens work.
FS#9710. I don't really remember why it was rejected, if you're game we can try bringing it back. especially now that the buffer usage is 0 if you dont use the tokens.I want to nail down the tokens we want to support first though. is the current set good? or should they be fixed?
also, we need to deprecate LANG_FM_STATION and come up with a new label for it. Changing the source string is BAD! especially when its fed directly to printf
I want to commit this already, so testers neded
The backdrop only gets drawn in viewports - the same issue as was fixed for the WPS in r24571
If the fms contains %C it breaks on target (but not on sim). I know %C isn't supported yet for fms, but JdGordon requested I pop it here :)
attached should fix the backdrop isssue. I'm commiting this tomorow night!
I don't think we need to add special handling for the next one because the playlist viewer is a better way to do this?
no other changes in this version.
dump1 attached shows a scrolling line in the WPS, and dump2 shows the menu immediately after leaving the fms
There is also a small glitch at the top of the fms where the menu backdrop shows through the section of the UI viewport there. This also happens on the WPS, but SVN is fine.
I can attach the theme if needed.
can you upload a theme with the scrolling issue?
Thanks :)
There is a problem where there isnt enough room on the buffer for the fms on non colour targets, so if you test on mono/grey then modify line 58 of apps/gui/skin_engine/skin_buffer.c. change that 2 to some larger number (10 or 12 perhaps) and it should work.
1. In the main menu, while FM Radio is highlighted, if you bring up the context menu and load a preset file you are taken into the FM screen after the file is loaded. If there is a progress bar in the FMS (including the in-built default), the progress bar does not work. The progress bar will work properly if you exit the radio screen and reenter.
2. In scan mode, I use this %?Tn<%s%ac%Tn|%Tf> to display a presets name (or frequency if it is unnamed) when a presets frequency is tuned. When not on a preset frequency, the preset name of the highest preset is displayed. I am attaching a fix for this, although it may not be the best way to handle this issue.
Michael I dont quite understand your fix?
change skin_tokens.c line 390 from "if (radio_preset_count() == 0)" to "if (radio_preset_count() == 0 || preset == -1)"