Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10865 - Mandelbrot: Yield buttons during painting of the fractal

Attached to Project: Rockbox
Opened by Tomer Shalev (tomers) - Thursday, 17 December 2009, 19:44 GMT+2
Last edited by Tomer Shalev (tomers) - Wednesday, 13 January 2010, 20:08 GMT+2
Task Type Patches
Category Plugins
Status Closed
Assigned To Tomer Shalev (tomers)
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.4
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

In Mandelbrot demo application, increasing iteration depth causes slow painting of the fractal. The painting function yields during the painting, but does not responds to user interactions. If you want to move / zoom in/out the fractal, you have to wait until drawing ends.

This implementation yields the buttons during painting (each 0.25 sec).

Currently, pressing a button redraws the entire screen. This can be optimized further, but it is better in terms of usability than current implementation. I don't see a reason for it to hurt drawing performance much.

I would like to get some more comments for this so I know if its ready to be committed,
   mandelbrot_button_yield.diff (7.9 KiB) 
 apps/plugins/mandelbrot.c |  142 ++++++++++++++++++++++++++++++++++++----------
 1 file changed, 113 insertions(+), 29 deletions(-)

This task depends upon

Closed by  Tomer Shalev (tomers)
Wednesday, 13 January 2010, 20:08 GMT+2
Reason for closing:  Out of Date
Additional comments about closing:  Superseded by:
 FS#10911  - Plugins: Fractals (formerly Mandelbrot)
Comment by Teruaki Kawashima (teru) - Saturday, 19 December 2009, 13:35 GMT+2
I'd prefer something like this: check tick before calling check_button() and check_button() returns button code.
   mandelbrot_button_yield.2.diff (7.4 KiB) 
 apps/plugins/mandelbrot.c |  130 ++++++++++++++++++++++++++++++++++++----------
 1 file changed, 103 insertions(+), 27 deletions(-)

Loading...