Rockbox

Tasklist

FS#10896 - Changed default codepage is applied only afterl reboot

Attached to Project: Rockbox
Opened by Tomer Shalev (tomers) - Wednesday, 06 January 2010, 05:48 GMT
Last edited by Alexander Levin (fml2) - Wednesday, 05 May 2010, 21:23 GMT
Task Type Bugs
Category Font/charset
Status New
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Release 3.5
Due Date Undecided
Percent Complete 0%
Votes 0
Private No

Details

Tested on r24190-100105

To reproduce:
- Start Rockbox, default setting
- Play a file with ID3 tags which are encoded in some non-Latin locale (In my case, Hebrew). Notice that the strings are shown in Gibberish.
- Change Default Codepage to the other locale (e.g. Hebrew).
- Go back to WPS

Expected result: All strings that are encoded in the other locale are shown properly.
Current result: All these strings are shown in the original locale.

Workaround: Restart the player. The new locale is applied.

I will not have time to fix this myself, so I'll appreciate if someone else can take responsibility for this bug. Thanks.
This task depends upon

Comment by Teruaki Kawashima (teru) - Wednesday, 06 January 2010, 09:09 GMT
I think you don't need to restart the player to take effect the change of codepage.
But you need to reload music files because strings are usualy converted to UTF-8 when they are loaded.
Comment by Tomer Shalev (tomers) - Wednesday, 06 January 2010, 09:24 GMT
> I think you don't need to restart the player to take effect the change of codepage.
> But you need to reload music files because strings are usually converted to UTF-8 when they are loaded.

This workaround works too, but it is still a workaround, as the expected behavior is that changes should take effect immediately.
I'm almost sure it used to worked this way previously.
Comment by Jonathan Gordon (jdgordon) - Friday, 15 January 2010, 04:37 GMT
try putting a audio_stop() and audio_resume() in the callback for the codepage change.. that should cause the files to be rebuffered

Loading...