Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10898 - playlist viewer WPS widget

Attached to Project: Rockbox
Opened by Jonathan Gordon (jdgordon) - Thursday, 07 January 2010, 08:25 GMT+2
Last edited by Jonathan Gordon (jdgordon) - Wednesday, 13 January 2010, 07:02 GMT+2
Task Type Patches
Category Themes
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.4
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

I dont know if this is going to ever make it into svn, but its going here incase I lose interest...

Attached is a screenshot and the diff... The idea of this patch is to allow the WPS to have a playlist viewer displayed. to do this simply add the token %Vp to any viewport and the entire viewport will be used for the list it will show the the next tracks untill there is no more room.

tracks which have already been buffered will be displayed as "playlist number: title time", tracks which havnt been buffered yet will show the filename.

I'm hoping to make the text that is displayed be customisable using the skin language (!), also, I wanted to make it so you can choose which track to start the viewer at, so you could display the previous track down, or the current track down... this crashes so its hardcoded to start at the next track.

lots of work to do on this still... if anyone wants to take over let me know!
   dump 100106-230725.bmp (75.7 KiB)
   playlistviewer.diff (6 KiB) 
 apps/gui/skin_engine/skin_parser.c   |   19 ++++++++++++
 apps/gui/skin_engine/skin_display.c  |   52 +++++++++++++++++++++++++++++++++++
 apps/gui/skin_engine/skin_tokens.h   |    1 
 apps/gui/skin_engine/wps_internals.h |    8 +++++
 apps/playback.c                      |   17 +++++++++++
 apps/playback.h                      |    1 
 6 files changed, 98 insertions(+)

This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Wednesday, 13 January 2010, 07:02 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  in 24220.
Comment by Jonathan Gordon (jdgordon) - Friday, 08 January 2010, 06:38 GMT+2
update: this one shows that the text can be loaded from the skin... right now its hardcoded but its a nice demo
   playlistviewer.diff (10.1 KiB) 
 apps/gui/skin_engine/skin_parser.c   |   94 +++++++++++++++++++++++++++++++++++
 apps/gui/skin_engine/skin_display.c  |   74 +++++++++++++++++++++++++++
 apps/gui/skin_engine/skin_tokens.h   |    1 
 apps/gui/skin_engine/wps_internals.h |   21 +++++++
 apps/playback.c                      |   17 ++++++
 apps/playback.h                      |    1 
 6 files changed, 208 insertions(+)

Comment by Jonathan Gordon (jdgordon) - Tuesday, 12 January 2010, 07:16 GMT+2
Updated:
the skin language is now looking like:
%Vp|<offset>|<code to show if id3>|<show me otherwise>|
the offset is how far from the current track to start displaying. 0 is the current track, 1 is the next track, etc

The code in the next two parts is a very limited skin code. NO conditionals, and just about no tags are supported... the following list are supported:
<free text>
%pp - playlist position
%fn - file name
%fp - file path
%ia - artist
%it - track title
%pt - track length
%s - scroll the whole line


add suggestions for which other tags to add support for in the forum thread
   test.wps (0.3 KiB)
   playlistviewer.diff (12.1 KiB) 
 apps/gui/skin_engine/skin_parser.c   |  112 +++++++++++++++++++++++++++++++++++
 apps/gui/skin_engine/skin_tokens.c   |    2 
 apps/gui/skin_engine/skin_display.c  |   93 +++++++++++++++++++++++++++++
 apps/gui/skin_engine/skin_tokens.h   |    2 
 apps/gui/skin_engine/wps_internals.h |   22 ++++++
 apps/playback.c                      |   17 +++++
 apps/playback.h                      |    1 
 7 files changed, 248 insertions(+), 1 deletion(-)

Loading...