Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10982 - New WPS tag: %Tk

Attached to Project: Rockbox
Opened by Jens Theeß (punkt) - Monday, 08 February 2010, 20:57 GMT+2
Last edited by Jonathan Gordon (jdgordon) - Wednesday, 24 February 2010, 07:19 GMT+2
Task Type Patches
Category Themes
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch adds a new tag %Tk. This works exactly the same as %Tl, except that it turns true on touchscreen release instead of touchscreen press. This can be used to implement a WPS where the first touch displays a viewport with buttons, and a second touch then activates a button.

A modified version of the Fidelity theme which I use to test this feature can be found here:
http://www.theess.de/assets/files/Fidelity_Tk.zip

Link to the discussion on rockbox-dev:
http://www.rockbox.org/mail/archive/rockbox-dev-archive-2010-02/0022.shtml
   wps_tk.patch (3.6 KiB) 
 apps/gui/skin_engine/skin_parser.c |    1 +
 apps/gui/skin_engine/skin_tokens.c |    8 ++++++++
 apps/gui/skin_engine/skin_tokens.h |    1 +
 firmware/drivers/button.c          |    9 +++++++++
 firmware/export/button.h           |    1 +
 5 files changed, 20 insertions(+)

This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Wednesday, 24 February 2010, 07:19 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  thanks! in r24876.
Comment by Jonathan Gordon (jdgordon) - Tuesday, 09 February 2010, 06:36 GMT+2
do you want to try getting %Tl working better? or should we just accept this patch?
Comment by Jens Theeß (punkt) - Tuesday, 09 February 2010, 11:46 GMT+2
I'd like to look into %Tl this weekend. I recommend putting the %Tk patch on hold until then.
Comment by Jens Theeß (punkt) - Sunday, 14 February 2010, 00:24 GMT+2
Here's another take on the matter. As stated in the discussion on the mailing list, my intent is to provide a functionality similar to the original D2 firmware, where the first touch displays touch buttons, which can then be operated using subsequent touches. %Tl in its current form is insufficient: when I touch the display, the buttons are displayed, and the button at the position I touched is immediately triggered. To work around this issue, I made the %Tk patch which my theme uses to show the buttons on a touch release.

The new patch takes a different approach: It modifies the behaviour of touch buttons to be more similar to the way gui buttons operate in desktop applications. Upon a touch press event, the button at the touch position is armed. Upon a touch repeat or release, the button at the touch position is triggered only if it is armed. Upon release (and wps entry), all buttons are disarmed. E.g. when you touch press on an empty area, then while pressing drag your finger on a button, then release the button, the button is not triggered.

The new patch obsoletes the %Tk patch, as the behaviour I want to have can now be achieved using %Tl.
   touchregion_armed.patch (4.1 KiB) 
 apps/gui/skin_engine/skin_parser.c   |    1 
 apps/gui/skin_engine/wps_internals.h |    2 +
 apps/gui/wps.c                       |   37 ++++++++++++++++++++++++++++++++---
 3 files changed, 37 insertions(+), 3 deletions(-)

Comment by Jens Theeß (punkt) - Sunday, 14 February 2010, 03:00 GMT+2
Here's the theme used for testing the new patch: http://www.theess.de/assets/files/Fidelity_Tl.zip

Loading...