Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11065 - Disable line out for iPod Video

Attached to Project: Rockbox
Opened by Andree Buschmann (Buschel) - Saturday, 27 February 2010, 20:52 GMT+2
Last edited by Andree Buschmann (Buschel) - Saturday, 20 March 2010, 16:02 GMT+2
Task Type Patches
Category Drivers
Status Closed
Assigned To No-one
Player Type iPod 5G
Severity Low
Priority Normal
Reported Version Release 3.4
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

The lineout of the iPod Video consumes 0.5-0.6 mA even if there is no sink connected. To save some power and reach longer battery runtime it is reasonable to implement an option to be able to switch off the lineout. The battery lifetime is ~30 minutes longer with this setting.

This patch combines the lineout on/off with the accessory voltage supply. Switching off the accessory supply will also switch off the lineout. As this combination might mix up different things and usecases -- e.g. using lineout without any accessory device but simple adaptor -- I would prefer to introduce a new system setting.
   lineout_v01.patch (2.1 KiB) 
 firmware/export/wm8758.h                      |    1 +
 firmware/target/arm/ipod/powermgmt-ipod-pcf.c |    3 +++
 firmware/drivers/audio/wm8758.c               |   17 +++++++++++++++++
 3 files changed, 21 insertions(+)

This task depends upon

Closed by  Andree Buschmann (Buschel)
Saturday, 20 March 2010, 16:02 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Submitted with r25257.
Comment by MichaelGiacomelli (saratoga) - Saturday, 27 February 2010, 21:56 GMT+2
Isn't there a GPIO pin or similar that can be used to detect a line out accessory? I might be confusing it with the Sansas, but I though docks short two pins together to enable line out.
Comment by Andree Buschmann (Buschel) - Sunday, 28 February 2010, 16:49 GMT+2
I have played around with some adaptors and did not find any way to detect a connected accessory. Additionally I have used a self-made adaptor to perform some measurements. Those measurements showed that a) Apple FW had accessory supply enabled always b) Apple FW had the lineouts active all the time.

My question in the first post should not open new discussions about the accessory detection -- this has been done and (for now to me) there is no way knwon for automatic detection. My question was if it is acceptable to create a new setting or if I shall implement the lineout-disabling as done in this patch. This way any user who is using his iPod's lineout on a dock connector / adaptor, that does not need power supply via the iPod, will loose battery runtime as he must enable the accessory power supply.
Comment by Andree Buschmann (Buschel) - Saturday, 20 March 2010, 15:49 GMT+2
This new patch introduces the new system setting "Line-out".
   lineout_v02.patch (7.3 KiB) 
 apps/lang/english.lang                        |   18 +++++++++++++++++-
 apps/settings.h                               |    3 +++
 apps/menus/settings_menu.c                    |    6 ++++++
 apps/settings_list.c                          |    4 ++++
 apps/features.txt                             |    4 ++++
 apps/main.c                                   |    3 +++
 firmware/export/wm8758.h                      |    1 +
 firmware/export/powermgmt.h                   |    3 +++
 firmware/export/config/ipodvideo.h            |    3 +++
 firmware/target/arm/ipod/powermgmt-ipod-pcf.c |    9 +++++++++
 firmware/drivers/audio/wm8758.c               |   17 +++++++++++++++++
 uisimulator/common/powermgmt-sim.c            |    7 +++++++
 manual/configure_rockbox/system_options.tex   |    8 ++++++++
 13 files changed, 85 insertions(+), 1 deletion(-)

Loading...