Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11077 - WAV file playback does not resume

Attached to Project: Rockbox
Opened by Jeffrey Goode (Blue_Dude) - Friday, 05 March 2010, 01:26 GMT+2
Last edited by Yoshihisa Uchida (Uchida) - Monday, 22 March 2010, 11:05 GMT+2
Task Type Bugs
Category Music playback
Status Closed
Assigned To Yoshihisa Uchida (Uchida)
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

WAV files do not resume from "Resume Playback" or from bookmarks. Instead, they start from the beginning. This is a recent bug, I suspect dating from the wav codec update a couple of weeks ago. Current build is r25028.
This task depends upon

Closed by  Yoshihisa Uchida (Uchida)
Monday, 22 March 2010, 11:05 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  patch commited.
Comment by Yoshihisa Uchida (Uchida) - Monday, 08 March 2010, 13:41 GMT+2
The ploblem was confirmed. And this has been happened not only WAV but also other codecs.
How in your player? (wav only?)

comment add ---
The cause of this problem turned out.
However, please wait for a while to resume wav codec to all wave formats normally. (PCM is easy but ADPCM is difficult).
Comment by Yoshihisa Uchida (Uchida) - Tuesday, 09 March 2010, 11:43 GMT+2
I upload this bug's patch.
Please confirm it.
   rb_wav_resume.patch (23.6 KiB) 
 b/apps/codecs/aiff.c                      |   28 +++++++++++++++++++---
 b/apps/codecs/au.c                        |   27 +++++++++++++++++++--
 b/apps/codecs/libpcm/dialogic_oki_adpcm.c |   20 ++++++++--------
 b/apps/codecs/libpcm/dvi_adpcm.c          |    8 ++++--
 b/apps/codecs/libpcm/ieee_float.c         |    8 ++++--
 b/apps/codecs/libpcm/itut_g711.c          |    8 ++++--
 b/apps/codecs/libpcm/linear_pcm.c         |    8 ++++--
 b/apps/codecs/libpcm/ms_adpcm.c           |    8 ++++--
 b/apps/codecs/libpcm/pcm_common.h         |   13 ++++++++--
 b/apps/codecs/libpcm/qt_ima_adpcm.c       |    8 ++++--
 b/apps/codecs/libpcm/swf_adpcm.c          |   15 ++++++------
 b/apps/codecs/libpcm/yamaha_adpcm.c       |   11 ++++----
 b/apps/codecs/smaf.c                      |   27 +++++++++++++++++++--
 b/apps/codecs/vox.c                       |   37 ++++++++++++++++++++++--------
 b/apps/codecs/wav.c                       |   16 +++++++++---
 b/apps/codecs/wav64.c                     |   16 +++++++++---
 b/apps/metadata/au.c                      |    3 ++
 b/apps/metadata/smaf.c                    |    3 +-
 b/apps/metadata/vox.c                     |    1 
 19 files changed, 193 insertions(+), 72 deletions(-)

Comment by Yoshihisa Uchida (Uchida) - Sunday, 14 March 2010, 06:47 GMT+2
sync r25161
   rb_wav_resume_2.patch (22.1 KiB) 
 b/apps/codecs/aiff.c                      |   28 +++++++++++++++++++---
 b/apps/codecs/au.c                        |   27 +++++++++++++++++++--
 b/apps/codecs/libpcm/dialogic_oki_adpcm.c |   20 ++++++++--------
 b/apps/codecs/libpcm/dvi_adpcm.c          |    8 ++++--
 b/apps/codecs/libpcm/ieee_float.c         |    8 ++++--
 b/apps/codecs/libpcm/itut_g711.c          |    8 ++++--
 b/apps/codecs/libpcm/linear_pcm.c         |    8 ++++--
 b/apps/codecs/libpcm/ms_adpcm.c           |    8 ++++--
 b/apps/codecs/libpcm/pcm_common.h         |   13 ++++++++--
 b/apps/codecs/libpcm/qt_ima_adpcm.c       |    8 ++++--
 b/apps/codecs/libpcm/swf_adpcm.c          |   15 ++++++------
 b/apps/codecs/libpcm/yamaha_adpcm.c       |   11 ++++----
 b/apps/codecs/smaf.c                      |   25 +++++++++++++++++++-
 b/apps/codecs/vox.c                       |   37 ++++++++++++++++++++++--------
 b/apps/codecs/wav.c                       |   16 +++++++++---
 b/apps/codecs/wav64.c                     |   16 +++++++++---
 b/apps/metadata/vox.c                     |    1 
 17 files changed, 188 insertions(+), 69 deletions(-)

Comment by Jeffrey Goode (Blue_Dude) - Sunday, 21 March 2010, 01:52 GMT+2
This patch appears to correct the problem. It also appears to fix all related codecs. I'd commit this. Thanks!

Loading...