Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11096 - %Tl: Set the last touch time intially to 0

Attached to Project: Rockbox
Opened by Jens Theeß (punkt) - Friday, 12 March 2010, 22:39 GMT+2
Last edited by Jonathan Gordon (jdgordon) - Tuesday, 15 June 2010, 08:55 GMT+2
Task Type Patches
Category Themes
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

As it is now, last_touchscreen_touch is initialized to 0xffff, which is in the future. Therefore %Tl is true at rockbox start, and doesn't turn to false after the timeout of %Tl elapsed. This seems wrong, since the user hasn't actually touched yet.

With the proposed patch, %Tl is also true at rockbox start, but turns to false after the timeout elapses.

I thought of initializing last_touchscreen_touch to INT_MIN, but that didn't work for some reason.
   last_touchscreen_touch.diff (0.4 KiB) 
 firmware/drivers/button.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Tuesday, 15 June 2010, 08:55 GMT+2
Reason for closing:  Accepted
Comment by Jonathan Gordon (jdgordon) - Wednesday, 24 March 2010, 11:05 GMT+2
does this fix the problem? I tried in the sim and got nowhere
   touchchange.diff (0.8 KiB) 
 apps/gui/skin_engine/skin_tokens.c |    8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

Comment by Jens Theeß (punkt) - Saturday, 27 March 2010, 15:06 GMT+2
That fix works for me in the sim.

Loading...