Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11110 - Fix alarmclock plugin time miscalculation

Attached to Project: Rockbox
Opened by Clément Pit--Claudel (CFP) - Monday, 15 March 2010, 21:08 GMT+2
Last edited by Rafaël Carré (funman) - Saturday, 15 May 2010, 17:21 GMT+2
Task Type Patches
Category Plugins
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Fix alarmclock plugin. The time calculation is wrong, and the alarm may eventually not ring.
Should fix it (hopefully :))
   fix-alarmclock.diff (1.3 KiB) 
 apps/plugins/alarmclock.c |   14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

This task depends upon

Closed by  Rafaël Carré (funman)
Saturday, 15 May 2010, 17:21 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  r26056
Comment by Clément Pit--Claudel (CFP) - Monday, 15 March 2010, 21:21 GMT+2
Update following funman's suggestions.
   fix-alarmclock-2.diff (1.3 KiB) 
 apps/plugins/alarmclock.c |   14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

Comment by Clément Pit--Claudel (CFP) - Monday, 15 March 2010, 22:15 GMT+2
Woops, there was a problem when setting the alarm to 00:00.
   fix-alarmclock-3.diff (1.7 KiB) 
 apps/plugins/alarmclock.c |   20 +++++++++++++++-----
 1 file changed, 15 insertions(+), 5 deletions(-)

Comment by Clément Pit--Claudel (CFP) - Wednesday, 07 April 2010, 18:21 GMT+2
Ok, I've though of a proper fix for this, the above patch used quite an ugly solution, this one should be good.
Comment by Clément Pit--Claudel (CFP) - Wednesday, 07 April 2010, 18:21 GMT+2
Wooops, forgot the file.
   properfix.diff (1.6 KiB) 
 apps/plugins/alarmclock.c |   19 +++++++++++++------
 1 file changed, 13 insertions(+), 6 deletions(-)

Loading...