Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11133 - skin display: use the tags to draw images/etc instead of all in one hit at the end

Attached to Project: Rockbox
Opened by Jonathan Gordon (jdgordon) - Sunday, 21 March 2010, 10:15 GMT+2
Last edited by Jonathan Gordon (jdgordon) - Thursday, 05 August 2010, 15:07 GMT+2
Task Type Patches
Category Themes
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.4
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

in svn all images are drawn in a loop at the end of each viewport, this means you cant do funky stuff like writing over images, and it makes the order less obvious.

This patch aims to give the user more options on when to draw images.
   draw_order.1.diff (2.6 KiB) 
 apps/gui/skin_engine/skin_tokens.c  |    4 +--
 apps/gui/skin_engine/skin_display.c |   46 ++----------------------------------
 2 files changed, 5 insertions(+), 45 deletions(-)

This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Thursday, 05 August 2010, 15:07 GMT+2
Reason for closing:  Out of Date
Comment by Jonathan Gordon (jdgordon) - Sunday, 21 March 2010, 11:02 GMT+2
small update, this adds progressbar and AA to the image draew order change, so look outt for wierdness there
   draw_order.2.diff (6.1 KiB) 
 apps/gui/skin_engine/skin_tokens.c   |    4 -
 apps/gui/skin_engine/skin_display.c  |   84 ++++++-----------------------------
 apps/gui/skin_engine/wps_internals.h |    1 
 3 files changed, 18 insertions(+), 71 deletions(-)

Comment by Jonathan Gordon (jdgordon) - Sunday, 21 March 2010, 11:55 GMT+2
fix %x tag
   draw_order.3.diff (6.6 KiB) 
 apps/gui/skin_engine/skin_tokens.c   |    4 -
 apps/gui/skin_engine/skin_display.c  |   95 +++++++++--------------------------
 apps/gui/skin_engine/wps_internals.h |    1 
 3 files changed, 29 insertions(+), 71 deletions(-)

Comment by Jonathan Gordon (jdgordon) - Sunday, 21 March 2010, 13:46 GMT+2
fix %x again
   draw_order.4.diff (7.4 KiB) 
 apps/gui/skin_engine/skin_parser.c   |    6 +-
 apps/gui/skin_engine/skin_tokens.c   |    4 -
 apps/gui/skin_engine/skin_display.c  |   95 +++++++++--------------------------
 apps/gui/skin_engine/wps_internals.h |    1 
 4 files changed, 34 insertions(+), 72 deletions(-)

Comment by Andy (cbs_ghost) - Sunday, 28 March 2010, 16:23 GMT+2
What option? How to use it? Let me know!
Comment by Jonathan Gordon (jdgordon) - Monday, 17 May 2010, 13:12 GMT+2
resynced
   draw_order.5.diff (6 KiB) 
 apps/gui/skin_engine/skin_parser.c   |    6 ++-
 apps/gui/skin_engine/skin_tokens.c   |   17 ++++++--
 apps/gui/skin_engine/skin_display.c  |   69 +++--------------------------------
 apps/gui/skin_engine/wps_internals.h |    1 
 4 files changed, 24 insertions(+), 69 deletions(-)

Comment by Jonathan Gordon (jdgordon) - Monday, 17 May 2010, 14:01 GMT+2
new version. This makes the progressbars draw in the tag like I want.
Also, new tag, %aZ will make the text in that line draw over the images currently drawn without clearing them (wont work on scrolling lines)
   draw_order.6.diff (10.1 KiB) 
 apps/gui/skin_engine/skin_parser.c   |    7 +-
 apps/gui/skin_engine/skin_tokens.c   |   17 ++++-
 apps/gui/skin_engine/skin_display.c  |  113 +++++++----------------------------
 apps/gui/skin_engine/skin_tokens.h   |    1 
 apps/gui/skin_engine/wps_internals.h |    2 
 5 files changed, 46 insertions(+), 94 deletions(-)

Comment by Jonathan Gordon (jdgordon) - Wednesday, 09 June 2010, 11:45 GMT+2
undo the %aZ thing... this one wants to be commited
   draw_order.7.diff (8.7 KiB) 
 apps/gui/skin_engine/skin_parser.c   |    7 +-
 apps/gui/skin_engine/skin_tokens.c   |   17 ++++--
 apps/gui/skin_engine/skin_display.c  |   98 +++--------------------------------
 apps/gui/skin_engine/wps_internals.h |    3 -
 4 files changed, 27 insertions(+), 98 deletions(-)

Loading...