Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11141 - Do not boost while buffering when DMA is used

Attached to Project: Rockbox
Opened by Andree Buschmann (Buschel) - Tuesday, 23 March 2010, 22:11 GMT+2
Last edited by Andree Buschmann (Buschel) - Sunday, 09 January 2011, 20:05 GMT+2
Task Type Patches
Category Drivers
Status Closed
Assigned To Andree Buschmann (Buschel)
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.4
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch was extracted from  FS#9708 . It removes the boost/unboost for buffering when HAVE_ATA_DMA is defined. Reason to do so is: a) buffering speed does not depent on CPU boost when DMA is used, b) boosting shall only be used, if neccessary.
   alignment_unboost_v02.patch (0.7 KiB) 
 apps/buffering.c |    6 ++++++
 1 file changed, 6 insertions(+)

This task depends upon

Closed by  Andree Buschmann (Buschel)
Sunday, 09 January 2011, 20:05 GMT+2
Reason for closing:  Rejected
Additional comments about closing:  Will not be submitted to svn and has some flaws (e.g. not taking into account whether the connected drive really uses DMA).
Comment by Seheon Ryu (cpu98) - Tuesday, 23 March 2010, 22:51 GMT+2
I forgot to report to  FS#9708 :
ata.v9.patch + buffer_cacheline_alignment_v3.patch combo(that I said unstable for mine long ago, currently in svn) worked fine.
Maybe that was other buffering problem then.
Bye.
Comment by Seheon Ryu (cpu98) - Tuesday, 23 March 2010, 22:53 GMT+2
correction:
ata.v9.'patch + buffer_cacheline_alignment_v3.patch' to
v9 + buffer _cache_alignment_v2
Comment by Torne Wuff (torne) - Wednesday, 24 March 2010, 09:43 GMT+2
It's not entirely clear what you mean; if you are still interested in testing this change, then test it on top of svn, which now includes all the DMA code.
Comment by Seheon Ryu (cpu98) - Wednesday, 24 March 2010, 17:44 GMT+2
I know current svn have them all and what I'm saying is not related to this patch.
Just wanted to report to him because I might have confused him before....
Thanks for worrying me.
Comment by Seheon Ryu (cpu98) - Wednesday, 24 March 2010, 17:48 GMT+2
OMG I terribly mistyped.
Thanks for worrying about me.
Comment by Andree Buschmann (Buschel) - Friday, 26 March 2010, 08:17 GMT+2
Sync'ed against r25340.
   alignment_unboost_v03.patch (0.7 KiB) 
 apps/buffering.c |    6 ++++++
 1 file changed, 6 insertions(+)

Loading...