Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11143 - buffering thread debug showing remote

Attached to Project: Rockbox
Opened by Ronald Malbosc (Chiyo-chan) - Wednesday, 24 March 2010, 22:11 GMT+2
Last edited by Jonathan Gordon (jdgordon) - Sunday, 25 April 2010, 14:01 GMT+2
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Hi,

To help me diagnotics my buffring problem, I added remote output to the buffering thread debug (added lcd_remote_puts juste before every lcd_puts on the right part of debug_menu.c).
I've added a patch to the current svn file.
As it's my first patch, let me know is anything isn't right.
   debug_menu.patch (4 KiB) 
 rockbox/apps/debug_menu.c |   39 +++++++++++++++++++++++++++++++++------
 1 file changed, 33 insertions(+), 6 deletions(-)

This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Sunday, 25 April 2010, 14:01 GMT+2
Reason for closing:  Fixed
Additional comments about closing:  done useing the correct API in r25712.
Comment by Rafaël Carré (funman) - Wednesday, 31 March 2010, 11:17 GMT+2
Did you try to build on a target without remote ?
Comment by Ronald Malbosc (Chiyo-chan) - Wednesday, 31 March 2010, 11:56 GMT+2
Nope, I didn't try that.
Comment by Ronald Malbosc (Chiyo-chan) - Wednesday, 31 March 2010, 18:49 GMT+2
Just tried.
Effectively problem during compile for a target without a LCD remote (tried iPod Video).
I've attached a new version of the patch which include correct (I think ^^) #ifdef.
   debug_menu.patch (4.7 KiB) 
 rockbox/apps/debug_menu.c |   76 +++++++++++++++++++++++++++++++++++++++++-----
 1 file changed, 68 insertions(+), 8 deletions(-)

Loading...