Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11159 - FM settings removal patch for funman

Attached to Project: Rockbox
Opened by Jonathan Gordon (jdgordon) - Wednesday, 31 March 2010, 13:45 GMT+2
Last edited by Thomas Martitz (kugel.) - Friday, 03 February 2012, 22:04 GMT+2
Task Type Patches
Category FM Tuner
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.4
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

untested patch, should make the bass and treble options disa[pear from the fm screens menu
   fm_settings.diff (1.2 KiB) 
 apps/menus/sound_menu.c |   27 +++++++++++++++++++++++++--
 1 file changed, 25 insertions(+), 2 deletions(-)

This task depends upon

Closed by  Thomas Martitz (kugel.)
Friday, 03 February 2012, 22:04 GMT+2
Reason for closing:  Out of Date
Additional comments about closing:  fixed in current version
Comment by Thomas Martitz (kugel.) - Wednesday, 31 March 2010, 14:01 GMT+2
It looks like the patch isn't going to work if you reach the fm settings via the main menu (i.e. the context menu of the radio item there).
Comment by Jonathan Gordon (jdgordon) - Wednesday, 31 March 2010, 14:33 GMT+2
which is how it shold probably work. The setting makes no difference to the radio which means it should only be hidden when it is directly got to from the radio, not through the mian menu.
Comment by Thomas Martitz (kugel.) - Wednesday, 31 March 2010, 14:55 GMT+2
The context menu of the radio item in the main menu is the exact same menu that shows from within the radio, it's the menu that's specific for the radio (with preset stuff and the like). As it's specific to the radio (as opposed to the settings->sound settings etc menus) it should also hide the bass&treble settings, shouldn't it?
Comment by Jonathan Gordon (jdgordon) - Wednesday, 31 March 2010, 15:01 GMT+2
so? and anyway funman asked for this, I have no idea what his plans are...
Comment by Rafaël Carré (funman) - Thursday, 01 April 2010, 00:53 GMT+2
kugel I think it should be hidden everywhere where it affects FM playback.

If you have a sansa (I bet you do) just try to change bass/treble: going up will just increase the overall volume, going down will have no effect
Comment by Jonathan Gordon (jdgordon) - Sunday, 06 June 2010, 15:40 GMT+2
this one actually works...
   fm_settings.diff (2.7 KiB) 
 apps/menus/sound_menu.c |   57 +++++++++++++++++++++++++++++++++++-------------
 1 file changed, 42 insertions(+), 15 deletions(-)

Loading...