This is the bug/patch tracker for Rockbox. Click here for more information.
Quick links: Bugs · Patches · Rockbox frontpage
FS#11189 - separate mas35xx lowlevel stuff
Attached to Project:
Rockbox
Opened by Marcin Bukat (MarcinBukat) - Wednesday, 07 April 2010, 23:08 GMT+2
Last edited by Marcin Bukat (MarcinBukat) - Sunday, 05 June 2011, 12:51 GMT+2
Opened by Marcin Bukat (MarcinBukat) - Wednesday, 07 April 2010, 23:08 GMT+2
Last edited by Marcin Bukat (MarcinBukat) - Sunday, 05 June 2011, 12:51 GMT+2
|
DetailsI did my best to separate mas lowlevel stuff from sound.c. I made various cleanups to handle mas code in more consistent way. I do not have any Archos device so this is not tested at all (although it compiles cleanly).
cleanup.diff
(60.4 KiB)
apps/codecs.c | 2 apps/recorder/radio.c | 2 apps/recorder/recording.c | 2 apps/recorder/peakmeter.c | 2 apps/menus/recording_menu.c | 2 apps/mpeg.c | 4 apps/plugin.h | 2 apps/debug_menu.c | 5 firmware/export/mascodec.h | 43 ++ firmware/export/mas.h | 184 ---------- firmware/export/mas35xx.h | 164 ++++++++- firmware/export/audiohw.h | 3 firmware/export/dac3550a.h | 47 ++ firmware/mp3_playback.c | 4 firmware/sound.c | 89 +---- firmware/test/i2c/main.c | 4 firmware/SOURCES | 15 firmware/target/sh/archos/mascodec-archos.c | 485 ++++++++++++++++++++++++++++ firmware/drivers/audio/dac3550a.c | 124 +++++++ firmware/drivers/audio/mas35xx.c | 99 +++++ firmware/drivers/dac.c | 119 ------ firmware/drivers/dac.h | 48 -- firmware/drivers/tuner/s1a0903x01.c | 2 firmware/drivers/mas.c | 485 ---------------------------- 24 files changed, 988 insertions(+), 948 deletions(-) |
This task depends upon
firmware/mp3_playback.c - contains SH specific code so should be moved to target specyfic file (at leas part of it)
apps/mpeg.c - contains a lot of code specific to MAS. This should be reviewed.
apps/plugin.h - exports a lot of MAS specific functions to be used in plugins
apps/plugins/starfield.c
apps/plugins/oscilloscope.c
apps/plugins/vu_meter.c
apps/plugins/splitedit.c - this plugins contain call to rb->mas_codec_readreg(0x0C) and rb->mas_codec_readreg(0x0D) to obtain peak value
apps/plugins/wavrecord.c
apps/plugins/wavplay.c - MAS specyfic
apps/recorder/radio.c - contains call to mas_codec_writereg(6, 0x4000);
apps/recorder/peakmeter.c - contains call to mas_codec_readreg(pm_src_left) and mas_codec_readreg(pm_src_right)
Sound settings all seem to work correctly. I went through the complete sound settings menu and listened to the difference when changing the setting as well as comparing the ranges to a build without the patch.
Available recording settings are all the same if I saw correctly. Two short test recordings (one with the internal mic, one from radio) worked. I was just testing the standards though - e.g. the resulting average bitrate looked correct (respecting the quality setting)
A wav recording worked correctly and I could play back the file with wavplay which sounded correctly too.
apps/mpeg.c
apps/plugins/starfield.c
apps/plugins/oscilloscope.c
apps/plugins/vu_meter.c
apps/plugins/splitedit.c - this plugins contain call to rb->mas_codec_readreg(0x0C) and rb->mas_codec_readreg(0x0D) to obtain peak value
apps/plugins/wavrecord.c
apps/plugins/wavplay.c - MAS specific (this can be left alone I think)
apps/recorder/radio.c - contains call to mas_codec_writereg(6, 0x4000);
apps/recorder/peakmeter.c - contains call to mas_codec_readreg(pm_src_left) and mas_codec_readreg(pm_src_right)