This is the bug/patch tracker for Rockbox. Click here for more information.
Quick links: Bugs · Patches · Rockbox frontpage
FS#11209 - rework the text viewer plugin.
Attached to Project:
Rockbox
Opened by Yoshihisa Uchida (Uchida) - Monday, 19 April 2010, 12:49 GMT+2
Last edited by Yoshihisa Uchida (Uchida) - Saturday, 05 June 2010, 13:55 GMT+2
Opened by Yoshihisa Uchida (Uchida) - Monday, 19 April 2010, 12:49 GMT+2
Last edited by Yoshihisa Uchida (Uchida) - Saturday, 05 June 2010, 13:55 GMT+2
|
DetailsI previously had committed wrong the new text viewer plugin, which was completed.
This not only split the file and reviews all logics, I have created many new functions, I think that there are problems that viewer.rock does not occur. Please check various players, text file and settings. Notes (1) Though I create the new text viewer the same behavior of the viewer.rock, some features are differently. (see "Difference between viewer.rock" in readme.txt) (2) If you apply this patch, the viewer.rock is created and if you viewer.config change, viewer.rock can be used. (3) In IRC, though I received the advice that I should remove "tv_" prefix from all file names, I did not change all file names because there exist already the sames or similar names. (4) I accept the feature request. But I do not add the new feature other than bug fixes until this task is closed. (I add only TODO list) 
rb_text_viewer.patch
(140.5 KiB)
b/apps/plugins/CATEGORIES | 1 b/apps/plugins/SUBDIRS | 1 b/apps/plugins/viewers.config | 4 b/apps/plugins/text_viewer/SOURCES | 12 b/apps/plugins/text_viewer/readme.txt | 60 ++ b/apps/plugins/text_viewer/text_viewer.c | 202 ++++++++ b/apps/plugins/text_viewer/text_viewer.make | 20 b/apps/plugins/text_viewer/tv_action.c | 177 +++++++ b/apps/plugins/text_viewer/tv_action.h | 119 +++++ b/apps/plugins/text_viewer/tv_bookmark.c | 302 +++++++++++++ b/apps/plugins/text_viewer/tv_bookmark.h | 85 +++ b/apps/plugins/text_viewer/tv_button.h | 413 +++++++++++++++++ b/apps/plugins/text_viewer/tv_menu.c | 349 +++++++++++++++ b/apps/plugins/text_viewer/tv_menu.h | 43 + b/apps/plugins/text_viewer/tv_pager.c | 337 ++++++++++++++ b/apps/plugins/text_viewer/tv_pager.h | 104 ++++ b/apps/plugins/text_viewer/tv_preferences.c | 119 +++++ b/apps/plugins/text_viewer/tv_preferences.h | 129 +++++ b/apps/plugins/text_viewer/tv_reader.c | 191 ++++++++ b/apps/plugins/text_viewer/tv_reader.h | 102 ++++ b/apps/plugins/text_viewer/tv_screen_pos.c | 41 + b/apps/plugins/text_viewer/tv_screen_pos.h | 56 ++ b/apps/plugins/text_viewer/tv_settings.c | 519 ++++++++++++++++++++++ b/apps/plugins/text_viewer/tv_settings.h | 73 +++ b/apps/plugins/text_viewer/tv_text_processor.c | 576 +++++++++++++++++++++++++ b/apps/plugins/text_viewer/tv_text_processor.h | 80 +++ b/apps/plugins/text_viewer/tv_text_reader.c | 91 +++ b/apps/plugins/text_viewer/tv_text_reader.h | 101 ++++ b/apps/plugins/text_viewer/tv_window.c | 393 +++++++++++++++++ b/apps/plugins/text_viewer/tv_window.h | 69 ++ 30 files changed, 4767 insertions(+), 2 deletions(-) |
This task depends upon
Closed by Yoshihisa Uchida (Uchida)
Saturday, 05 June 2010, 13:55 GMT+2
Reason for closing: Accepted
Additional comments about closing: the current patch commits (r26571).
Saturday, 05 June 2010, 13:55 GMT+2
Reason for closing: Accepted
Additional comments about closing: the current patch commits (r26571).
FS#7892and meanwhile accepted in current viewer as you can see inFS#2648. Jumping accidently to begin or end during reading is very anoying.updates patch file.
changes
- sync r26136
- merge from r25724, r25844, and r25844.
- when the narrow mode, left key: scroll to the previous page, right key: scroll to the next page.
new patch uploads.