This is the bug/patch tracker for Rockbox. Click here for more information.
Quick links: Bugs · Patches · Rockbox frontpage
FS#11234 - Rockbox as an Application
Attached to Project:
Rockbox
Opened by Thomas Martitz (kugel.) - Sunday, 02 May 2010, 03:09 GMT+2
Last edited by Thomas Martitz (kugel.) - Thursday, 22 December 2011, 16:51 GMT+2
Opened by Thomas Martitz (kugel.) - Sunday, 02 May 2010, 03:09 GMT+2
Last edited by Thomas Martitz (kugel.) - Thursday, 22 December 2011, 16:51 GMT+2
|
DetailsThis task should serve as a place for comments on my gsoc work. I also plan to upload patches here occasionally, although my work will always be available at http://repo.or.cz/w/kugel-rb.git.
See also: http://www.rockbox.org/wiki/RockboxAsAnApplication2010 |
This task depends upon
Closed by Thomas Martitz (kugel.)
Thursday, 22 December 2011, 16:51 GMT+2
Reason for closing: Accepted
Additional comments about closing: RaaA was a success!
Thursday, 22 December 2011, 16:51 GMT+2
Reason for closing: Accepted
Additional comments about closing: RaaA was a success!
Rework how standard C library handling is done.
* Move standard C libraries into firmware/libc and their headers into firmware/libc/includes.
* Don't compile these for the sim, and link the OS library instead, and fix up code that didn't work with that.
* This means a lot of clean up with w.r.t. to includes, so update most files.
* strlcpy/strlcat/strcasecmp/strcasecmp now in string-extra.h as they're not ANSI C.
The reason for this is that the application should use OS libraries to reduce memory usage and because the OS' libraries are likely better tailored to a specific machine. They also receive improvements and fixes over time which usually doesn't happen in our replacements.
[deleted patch as they're committed and rather long]
(it's separate commits for open and creat in my git repo).
[deleted patch as they're committed and rather long]
An extra change is that the startup is more target like. The entry point is in main.c and then the init functions are called by the main thread (previously the entry point was in uisdl.c, which created an extra thread which would take over the actual main thread).
[deleted patch as it's committed and rather long]
using the Gnu Pth thread library. It has some advantages over SDL threads
because it's cooperative by design and supports priorities.
It's not the default yet, enable via tools/configure --with-pth
[deleted patch as it's committed and rather long]
make: *** No rule to make target `/home/mcuelenaere/rockbox_git/buildt/backlight-target.h', needed by `/home/mcuelenaere/rockbox_git/buildt/firmware/backlight.o'. Stop.
On target, it's an inline function which does almost nothing, so there shouldn't be any change to them.
Why are so little other apps doing color-less notification icons?
Maybe they missed that part too ;). Or they don't care about this guideline, you can see this at the launcher icons of many apps too.
I made a new version of the statusbar icon (used Inkscape to create an svg image this time).
I made a screen dump I hope you can see what I mean
Well the gradient's color is also taken from the guideline and fits to the standard layout of the other status icons like th wlan- and 3g-indicator.
Your statusbar design is not the standard layout (looks like HTC Sense?)... well, maybe thats the point why many apps don't care about the guideline: it looks good at devices with the standard layout (Droid, Nexus One...), but not on others (HTC, Motorola with Blur, some Samsung phones).
About the tagcache, I bet yours works but I'd rather see it fixed properly. Increasing the stack size could work but I think there are generally some more problems with scanning the fs on hosted platforms.
Have found a bug in the key event code, for an example: there is no different between { ACTION_STD_CANCEL, BUTTON_DPAD_LEFT|BUTTON_REL, BUTTON_DPAD_LEFT } and { ACTION_STD_CANCEL, BUTTON_DPAD_LEFT, BUTTON_NONE } . I hope someone can fix this since I want to implement SEEKBACK and SEEKFWD in WPS.
How about Android RTC implementation since we can read Android localtime directly.
Also I see no reason that tagcache change isnt dont for all database targets. I imagine people would find it useful to not have part of their collection (i.e podcasts) in the db and this would be more obvious than the database.ignore.
For the tagcache patch, if it was not problematic at other targets I can just change it. Thank you.
Your english is fine :) and yes, change the tagcache patch to be for all DATABASE targets and it can go in.