Rockbox

Tasklist

FS#11240 - Allow lower volume for Cowon D2+

Attached to Project: Rockbox
Opened by Raphaël Jakse (jakse) - Wednesday, 05 May 2010, 11:27 GMT
Last edited by Andree Buschmann (Buschel) - Sunday, 30 May 2010, 18:29 GMT
Task Type Patches
Category Drivers
Status Closed
Assigned To Andree Buschmann (Buschel)
Operating System Cowon D2
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

I just installed Rockbox r25810-100504 on my Cowon D2+ player yesterday. It works quite well.
However, I find the lowest volume, which is -57 dB, too high. If I try -58 dB, the sound is turned off.

I usually listen to music at volume 2/3 with the original firmware, but the lowest volume in rockbox seems to be like volume 5 of the original firmware, which is too high for me when there isn't any noise .

I don't know wether it is a driver issue or not.

I don't know what category is best for this issue.
This task depends upon

Closed by  Andree Buschmann (Buschel)
Sunday, 30 May 2010, 18:29 GMT
Reason for closing:  Accepted
Additional comments about closing:  Submitted with r26413
Comment by Andree Buschmann (Buschel) - Wednesday, 05 May 2010, 19:05 GMT
This is not a bug but a change request :o)
If you take a look at  FS#10082  you will see that exactly this change was added to another audio codec driver. Are you able and willing to create a patch to attach it here?
Comment by Raphaël Jakse (jakse) - Thursday, 06 May 2010, 17:28 GMT
Thank you for your response.
I'm unfortunately not able to do the change because I have never writen driver code and I still don't know Cowon D2+ sound hardware. I installed rockbox 2 days ago and have not set any rockbox coding environement yet. I'm not familiar witch patches neither.
However, I can learn to do this and see what I can finely do I'll try to understand the patch you linked and make changes to the Cowon driver, but I'm not confident about testing it myself and it could be long before I can actually write any code...
Comment by Raphaël Jakse (jakse) - Thursday, 06 May 2010, 18:22 GMT
the audio codec, according to http://www.rockbox.org/wiki/CowonD2Info#Hardware , is the Wolfson WM8985. This could simplify the work as the patch linked in the first post is for the wm8758.
Comment by Andree Buschmann (Buschel) - Thursday, 06 May 2010, 20:10 GMT
Yes, the Cowon uses a WM8795. If you compare both the WM8985 and the WM8758 driver (especially before my change) you will see the related parts of source code are very very similar. I am confident that the  FS#10082  can be easily transferred to the WM8985 driver.
Comment by Raphaël Jakse (jakse) - Saturday, 29 May 2010, 08:36 GMT
Hi !
Good news, I come with two patches fixing the issue. I think it works, I only tried to play a mp3 file with.
First patch corrects the file wm8985.c, and the second corrects wm8985.h, where the constant VOLUME_MIN is defined. The first patch is likely to depends on the second, and vice versa.
My modifications are strongly inspired of the  FS#10082  patch.

I think It needs some testing / checking : I did it with lots of intuitions, and this is the first time I :
- patch something
- look at a driver code.

Hope that it will help somebody one day ;)
Comment by Andree Buschmann (Buschel) - Saturday, 29 May 2010, 16:28 GMT
Your changes look fine and compile :o)
I would like to have another tester to verify the functionality before I submit your changes.

Attached patch also corrects the manual.
Comment by Raphaël Jakse (jakse) - Sunday, 30 May 2010, 06:10 GMT
Thank you for having tested my patch :)

I had time to test more : It works with Ogg and Flac too. I think 90 dB turn the sound off as expected as I can hear a little noise when switching from 89 dB to 90 dB.
I played Rockblock while listening to music, too.

So yes, another tester would by great.
Comment by Raphaël Jakse (jakse) - Sunday, 30 May 2010, 06:10 GMT
-90db and -89dB, of course.
Comment by Andree Buschmann (Buschel) - Sunday, 30 May 2010, 07:19 GMT
Your changes affect the volume in general, this is independent of any codec.
Comment by Raphaël Jakse (jakse) - Sunday, 30 May 2010, 07:22 GMT
Yes, I know, but sometimes weird things happen.
I had a mp3 player with whitch I could listen mp3s with the volume 1 but not wma !
Strange,isn't it ?
Comment by Rob Purchase (shotofadds) - Sunday, 30 May 2010, 11:07 GMT
Thanks for working on this dysmann, I saw your comment a week or two ago and was about to try the same thing! I will test your patch later today with a view to getting it committed.
Comment by Andree Buschmann (Buschel) - Sunday, 30 May 2010, 15:22 GMT
shotofadds, just waiting for your approval of proper functionality. Then I will hit the button :o)
Comment by Rob Purchase (shotofadds) - Sunday, 30 May 2010, 18:01 GMT
It works like a charm. I can't check the exact ouptut levels, but I can tell you the upper range is unaffected, the lowest volume setting is barely perceptile with my in-ear buds, and the muting at -90 works fine. Go for it.

Loading...