This is the bug/patch tracker for Rockbox. Click here for more information.
Quick links: Bugs · Patches · Rockbox frontpage
FS#11245 - Hardware tone controls and hardware 3-D effect for Gigabeat S
Attached to Project:
Rockbox
Opened by Michael Sevakis (MikeS) - Thursday, 06 May 2010, 12:32 GMT+2
Last edited by Michael Sevakis (MikeS) - Saturday, 15 May 2010, 16:28 GMT+2
Opened by Michael Sevakis (MikeS) - Thursday, 06 May 2010, 12:32 GMT+2
Last edited by Michael Sevakis (MikeS) - Saturday, 15 May 2010, 16:28 GMT+2
|
DetailsThis utilizes the hardware equalizer in the WM8978 with a front end presenting them as tone controls. Filter cutoff settings are presented as well as enabling the Enhance 3d effect. All items are located in the Sound Settings submenu.
EQ bands: Bass, Low-Mid, Mid, High-Mid, Treble EQ frequency: Bass Cutoff, Low-Mid Center, Mid Center, High-Mid Center, Treble Cutoff 3D effect: 3-D Enhancement Edit: Additionally, I also hope to spur discussion to reach a consensus on just how to include these sort of hardware features in the sound menu in a friendly way and let it be the model. The fronting as tone controls just came from the idea of having another "EQ" in addition to the Rockbox software one as being possibly confusing to the user. 
gigabeat-s-eq-and-3d.diff
(29.1 KiB)
apps/lang/english.lang | 131 +++++++++++++++++++++++++++++++- apps/settings.h | 12 ++- apps/menus/sound_menu.c | 38 ++++++++- apps/settings_list.c | 16 +++- firmware/export/wm8978.h | 22 +++-- firmware/export/audiohw.h | 128 ++++++++++++++++++++++++++++++++ firmware/export/config/gigabeats.h | 3 firmware/export/sound.h | 9 ++ firmware/sound.c | 133 ++++++++++++++++++++++++++++++++- firmware/drivers/audio/wm8978.c | 147 ++++++++++++++++++++++++++++++++----- uisimulator/sdl/sound.c | 21 +++++ 11 files changed, 615 insertions(+), 45 deletions(-) |
This task depends upon
Closed by Michael Sevakis (MikeS)
Saturday, 15 May 2010, 16:28 GMT+2
Reason for closing: Accepted
Additional comments about closing: Went in later than planned after some additional smoothing-out.
Saturday, 15 May 2010, 16:28 GMT+2
Reason for closing: Accepted
Additional comments about closing: Went in later than planned after some additional smoothing-out.
Sound Menu
----Tone Controls
--------Low Shelf
--------Low Shelf Cutoff
--------Peak 1
--------Peak 1 Center
--------Peak 2
--------Peak 2 Center
--------Peak 3
--------Peak 3 Center
--------High Shelf
--------High Shelf Cutoff
----3-D Enhancement
Edit: Spaces don't indent
Edit
We have:
----Tone Controls
--------Band 1 Gain
--------Band 1 Frequency
--------Band 2 Gain
--------Band 2 Frequency
--------Band 2 Width
--------Band 3 Gain
--------Band 3 Frequency
--------Band 3 Width
--------Band 4 Gain
--------Band 4 Frequency
--------Band 4 Width
--------Band 5 Gain
--------Band 5 Frequency
----3-D Enhancement
Gains are highlighted with a different icon, the same used for Bass/Treble currently since in my estimation those settings are more likely to be sought out for changing than the others. Who knows, perhaps gains could be grouped together. I want to minimize menu depth. Perhaps it could have an "advanced" submenu containing all features, otherwise just gains + "Advanced Settings" under "Tone Controls". That's easy to rearrage without compatibility concerns.
With the basic Bass and Treble controls, obviously there's no explanation of their hardware or software nature, which depends on the whether the target has them in hardware. I think I'll avoid doing that unless it becomes the norm for Rockbox, which never explains it in the menus for other players that have their own hardware effects (like MAS codec Archos players).