Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11247 - Hotkey menu items have distinctive icon

Attached to Project: Rockbox
Opened by Jeffrey Goode (Blue_Dude) - Thursday, 06 May 2010, 18:27 GMT+2
Last edited by Jeffrey Goode (Blue_Dude) - Saturday, 08 May 2010, 04:20 GMT+2
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.4
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Hotkeyable menu items now have a distinctive icon. Color versions are red diamonds, 16 bit gray are darker gray. 1 and 2 color depth bitmaps are unchanged at present.
   icon.diff (6.6 KiB) 
 apps/onplay.c              |   16 ++++++++++------
 apps/gui/icon.h            |    1 +
 apps/menu.c                |    5 +++++
 apps/menus/settings_menu.c |    2 +-
 apps/menus/playlist_menu.c |    3 ++-
 apps/menu.h                |    1 +
 apps/player/icons.c        |    1 +
 7 files changed, 21 insertions(+), 8 deletions(-)

This task depends upon

Closed by  Jeffrey Goode (Blue_Dude)
Saturday, 08 May 2010, 04:20 GMT+2
Reason for closing:  Rejected
Additional comments about closing:  Superseded by later functionality
Comment by Jeffrey Goode (Blue_Dude) - Thursday, 06 May 2010, 20:16 GMT+2
Added a white dot to the default bitmaps. I don't know if that's enough to distinguish them, but it doesn't hurt anything. The tango_small bitmaps are better defined.

Here are all the bitmaps.
   tango_small.bmp (14 KiB)
   tango_small_mono.bmp (3.2 KiB)
   default_icons.6x8x1.bmp (5.2 KiB)
   default_icons.6x8x2.bmp (5.2 KiB)
   default_icons.6x8x16.bmp (5.2 KiB)
   remote_default_icons.6x8x1.bmp (5.2 KiB)
   remote_default_icons.6x8x2.bmp (5.2 KiB)
Comment by Jeffrey Goode (Blue_Dude) - Thursday, 06 May 2010, 21:03 GMT+2
Slightly better default icons.
   default_icons.6x8x1.bmp (5.2 KiB)
   default_icons.6x8x2.bmp (5.2 KiB)
   default_icons.6x8x16.bmp (5.2 KiB)
   remote_default_icons.6x8x1.bmp (5.2 KiB)
   remote_default_icons.6x8x2.bmp (5.2 KiB)
Comment by Jeffrey Goode (Blue_Dude) - Thursday, 06 May 2010, 22:09 GMT+2
Nicer outline on tango bitmap.
   tango_small.bmp (14 KiB)
Comment by Jeffrey Goode (Blue_Dude) - Friday, 07 May 2010, 19:22 GMT+2
New bitmaps didn't work so well. Here's an alternative idea. Also includes a menu setting to enable new icons. Disabled by default.
   icon.diff (2 KiB) 
 apps/menu.c                |    8 ++++++++
 apps/settings.h            |    2 ++
 apps/menus/settings_menu.c |    3 ++-
 apps/settings_list.c       |    2 ++
 4 files changed, 14 insertions(+), 1 deletion(-)

Comment by Alex Parker (BigBambi) - Friday, 07 May 2010, 19:55 GMT+2
This has been fairly extensively discussed in IRC today, but just to restate my personal views here :)

I don't see why hotkeys need specific icons. I would imagine that seeing a random different icons for some items is likely to confuse, not say "this item is hotkeyable". Also, this doesn't exist for other similar settable items, such as quickscreen items. Adding a menu item seems overkill to me, surely if anything this is a theme setting, to be set in icon files?

What about just changing the whole hotkey setting mechanism to a list, so you have two settings "WPS hotkey" and 2Menu hotkey" or something, within which you have a list of possibilities and then you just select the one you want? As I understand it there aren't so many hotkeyable items that the list would be too unwieldy.
Comment by Alexander Levin (fml2) - Friday, 07 May 2010, 23:38 GMT+2
I also think that there is no need in special hotkey icon which *replaces* the original icons. Maybe the hotkey sign should appear as an overlay icon (like in Windows' Explorer) but we don't have this possibility in Rockbox. I'd rather leave the icons as they are (i.e. no special icon for hotkeyable items) and show a "Not assignable to the hotkey" splash if the user presses the hotkey on a non-assignable item. Another argument is that hotkey is assigned only once or very rearily. So doesn't have to look good. Context menu, on the other hand, is use quite often, and hence should look good. And one aspect of "good" for me is that the eye is not disturbed by different icons.

A special setting for the hotkey would also be very good but I don't have a strong preference here. One huge advantage would be simple voicing and overall being in line with the Rockbox UI.

Loading...