Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11254 - Simple animation in USB screen

Attached to Project: Rockbox
Opened by Marcin Bukat (MarcinBukat) - Saturday, 08 May 2010, 22:29 GMT+2
Last edited by Marcin Bukat (MarcinBukat) - Sunday, 05 June 2011, 12:44 GMT+2
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.4
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

I always wonder when in USB mode if device is working or just hang. This patch adds simple animation to usb screen. This is rather proof-of-concept than full-fledged patch. I include here only single additional bitmap so to test effect of this patch please build sim for MPIO HD200 and press u to enter simulated USB mode.
This task depends upon

Closed by  Marcin Bukat (MarcinBukat)
Sunday, 05 June 2011, 12:44 GMT+2
Reason for closing:  Rejected
Additional comments about closing:  This doesn't geathered much attention.
Comment by Marcin Bukat (MarcinBukat) - Saturday, 08 May 2010, 22:31 GMT+2
Lost attachement
   animated_usb_screen.diff (4.2 KiB) 
 b/apps/bitmaps/native/SOURCES |    1 +
 b/apps/gui/usb_screen.c       |   15 +++++++++++++--
 2 files changed, 14 insertions(+), 2 deletions(-)

Comment by Brandon Dowdy (Brandonrd7) - Sunday, 09 May 2010, 13:23 GMT+2
can you remove the a and b at the beginning of the path please.
Comment by Rosso Maltese (asettico) - Sunday, 09 May 2010, 13:36 GMT+2
You can patch it with -p1 option, that trims the first level in the pathnames inside the patch.
HTH
Comment by Brandon Dowdy (Brandonrd7) - Sunday, 09 May 2010, 13:37 GMT+2
I actually use the TortoiseMerge application a lot. Have you heard of TortoiseSVN
Comment by Rosso Maltese (asettico) - Sunday, 09 May 2010, 13:40 GMT+2
Yes, of course. But I rarely use GUI to perform this type of actions.
It sounds quite strange to me that Tortoise doesn't provide this useful and option. Have you already investigate about that?
Comment by Brandon Dowdy (Brandonrd7) - Sunday, 09 May 2010, 13:42 GMT+2
No.
Comment by Marcin Bukat (MarcinBukat) - Sunday, 09 May 2010, 13:46 GMT+2
Another - simpler version. I preffer visual effect of the former patch but this has the advantage that it should run out of the box on every target without additional art work.
   animate_usb_screen.diff (1.3 KiB) 
 b/apps/gui/usb_screen.c |   13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

Comment by Jonathan Gordon (jdgordon) - Thursday, 20 May 2010, 17:08 GMT+2
how about this one :)

the numbers can be fiddled with to look smoother maybe, and need to make it work on the remotes...
   usbanimation.diff (1.2 KiB) 
 apps/gui/usb_screen.c |   10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

Comment by Jonathan Gordon (jdgordon) - Thursday, 20 May 2010, 17:35 GMT+2
and sync to svn.. and add remote image also
   usbanimation.diff (2.6 KiB) 
 apps/gui/usb_screen.c |   25 ++++++++++++++++++-------
 1 file changed, 18 insertions(+), 7 deletions(-)

Comment by Jonathan Gordon (jdgordon) - Thursday, 20 May 2010, 17:42 GMT+2
last one... go left>right when it fills fully
   usbanimation.diff (2.7 KiB) 
 apps/gui/usb_screen.c |   30 +++++++++++++++++++++++-------
 1 file changed, 23 insertions(+), 7 deletions(-)

Comment by Rafaël Carré (funman) - Friday, 09 July 2010, 22:57 GMT+2
- Build correctly when LCD_DEPTH == 1

However I'm not seeing the animation on Clipv1 nor Fuzev1.

With HID enabled, each time I change the HID mode I can see the next 'step', and with HID disabled nothing happens on keypress

What should cause the USB logo to animate?
   usbanimation.diff (3.1 KiB) 
 b/apps/gui/usb_screen.c |   36 +++++++++++++++++++++++++++++-------
 1 file changed, 29 insertions(+), 7 deletions(-)

Loading...