Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11265 - Beginning of the theme editor parser

Attached to Project: Rockbox
Opened by Robert Bieber (bieber) - Thursday, 13 May 2010, 04:16 GMT+2
Last edited by Jonathan Gordon (jdgordon) - Thursday, 05 August 2010, 15:06 GMT+2
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.4
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Laid some of the groundwork for a generic WPS parser for JdGordon's skinenginebreak branch
   patch (7.7 KiB)
This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Thursday, 05 August 2010, 15:06 GMT+2
Reason for closing:  Out of Date
Comment by Robert Bieber (bieber) - Thursday, 13 May 2010, 05:31 GMT+2
Updated version with tag table
   patch (13.6 KiB)
Comment by Robert Bieber (bieber) - Saturday, 15 May 2010, 10:26 GMT+2
Working on parser
   patch (24.7 KiB)
Comment by Robert Bieber (bieber) - Tuesday, 18 May 2010, 09:51 GMT+2
Working on parse_tag
   patch (27.9 KiB)
Comment by Jonathan Gordon (jdgordon) - Thursday, 20 May 2010, 11:21 GMT+2
the malloc line in skin_alloc_string(int length) looks like it alloca double the needed bytes?

other than that, I havnt looked at it enough to comment...
Comment by Robert Bieber (bieber) - Monday, 24 May 2010, 22:23 GMT+2
Good catch, I had the + 1 (to accomodate the \0 at the end of the string) in the wrong place. Here's a new patch (hopefully I'll have SVN access soon) that SHOULD parse any WPS document in your new format successfully, as long as the tags have been added to the tag table. I assumed that we'd use a conditional of the form

%?xx(option1,option2,option3)

since none was specified in your wiki document, just let me know if you'd rather some other format.
   patch (40.9 KiB)

Loading...