Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11273 - Format FM frequency depending on the regional settings

Attached to Project: Rockbox
Opened by Alexander Levin (fml2) - Friday, 14 May 2010, 11:00 GMT+2
Last edited by Alexander Levin (fml2) - Saturday, 15 May 2010, 23:58 GMT+2
Task Type Patches
Category FM Tuner
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.4
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

In some regions, the frequency is changed in 0.1 MHz steps, so that there's no need to display it with two digits after the decimal point. This patch formats the frequency as needed.
   fm_freq.diff (3.8 KiB) 
 apps/gui/skin_engine/skin_tokens.c |   36 +++++++++++++++++++++++++++---------
 manual/appendix/wps_tags.tex       |    8 +++-----
 2 files changed, 30 insertions(+), 14 deletions(-)

This task depends upon

Closed by  Alexander Levin (fml2)
Saturday, 15 May 2010, 23:58 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Committed in r26069
Comment by Jonathan Gordon (jdgordon) - Saturday, 15 May 2010, 11:39 GMT+2
looks fine.. can you get rid of the extra {}'s in the case WPS_TOKEN_TUNER_[MIN|MAX|CUR]FREQ cases? they make the switch a bit hard to read
Comment by Alexander Levin (fml2) - Saturday, 15 May 2010, 12:31 GMT+2
Yes, I will change the formatting function so that it returns the buf. Then all the switch cases can be written shorter.

Loading...