Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11300 - PictureFlow - Reflection Setting for small screens, Clip+

Attached to Project: Rockbox
Opened by Chris Savery (csavery) - Friday, 21 May 2010, 06:43 GMT+1
Task Type Patches
Category Plugins
Status Unconfirmed
Assigned To No-one
Player Type Another
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Private No

Details

This is a patch meant for Clip+ that adds a "Reflection" setting to PictureFlow.
This allows choosing if to show a reflection or not. When no reflection is shown the images are moved to bottom of screen allowing for title at top and keeping them in the blue area.
This will work for other devices. I tested it on Fuze v2 but others may have unknown problems related to screen size differences. For screens > 100 high it doesn't move the albums down.
Tested against r26185 in UISim only.
If you want this as a patch against my pictureflow-wps integration patch let me know as I have one here.
Enjoy.
   pictureflow-reflection.patch (3.2 KiB) 
 src/apps/plugins/pictureflow/pictureflow.c |   24 ++++++++++++++++++------
 1 file changed, 18 insertions(+), 6 deletions(-)

This task depends upon

Comment by Chris Savery (csavery) - Thursday, 10 June 2010, 09:53 GMT+1
Here is a new sync'd version of reflection and mono (FS#11310) combined against r26735.
Tested in Sim on Clip, Clip+ and Fuzev2 to see if any problems result. Looks fine here.
   pictureflow-reflection-mono.patch (5.3 KiB) 
 src/apps/plugins/pictureflow/pictureflow.c |   41 ++++++++++++++++++++++-------
 1 file changed, 32 insertions(+), 9 deletions(-)

Comment by Chris Savery (csavery) - Thursday, 10 June 2010, 16:10 GMT+1
Updated to choose mono mode based on HAVE_USEFUL_GREYLIB now also defined in config.h


   pictureflow-reflection-mono-2.patch (5.9 KiB) 
 src/apps/plugins/pictureflow/pictureflow.c |   42 ++++++++++++++++++++++-------
 src/firmware/export/config.h               |    8 +++++
 2 files changed, 41 insertions(+), 9 deletions(-)

Comment by Chris Savery (csavery) - Thursday, 10 June 2010, 18:23 GMT+1
Moved HAVE_USEFUL_GREYLIB into pictureflow.c so it's self contained.
   pictureflow-reflection-mono-3.patch (5.7 KiB) 
 src/apps/plugins/pictureflow/pictureflow.c |   46 +++++++++++++++++++++++------
 1 file changed, 37 insertions(+), 9 deletions(-)

Comment by Alejandro Arellano (Vague Rant) - Friday, 11 June 2010, 06:44 GMT+1
Using the first of these patches on Clip+ presently, works entirely as expected on target and sim.

One thing I'm curious about is how you're handling the zooming in the reflection-off mode. At zoom levels below 100%, the covers remain locked to the base of the screen, but above 100% the base expands off the bottom of the screen, whereas I feel it would make more sense to have the covers scale up (north) on the screen, as at 100% there's still some (blue) room above the covers, presumably because the 100% zoom level isn't designed to /fill/ the screen, but leaves space above and below. However, because you're leaving no space below there's just a gap above.

Currently making the sim, will attach a screenshot assuming it's the same there.
Comment by Alejandro Arellano (Vague Rant) - Friday, 11 June 2010, 08:03 GMT+1
Screen dump from simulator, note: scaled 2x for easier viewing, and gap is replaced by green bar to demonstrate its location more clearly.

Everything below the green line is in the blue section of the screen; as far as I can tell there's no way to fill that empty space.
   piczoomgap.png (4.3 KiB)

Loading...