Rockbox

Tasklist

FS#11313 - Add composer to track info screen.

Attached to Project: Rockbox
Opened by Chris Savery (csavery) - Monday, 24 May 2010, 16:26 GMT
Last edited by Jonathan Gordon (jdgordon) - Sunday, 30 May 2010, 15:26 GMT
Task Type Patches
Category Music playback
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

This patch exposes the composer tag in the track info screen (at the bottom, only if available).
I would have preferred it up under artist tag but it would have changed all the other tags too so I decided to keep it simple.
This requires a new lang id as well which means if it doesn't get into svn then we'll have to re-sync it more often.
Patched against r26251 and tested on Fuze v2 and Sim.
This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Sunday, 30 May 2010, 15:26 GMT
Reason for closing:  Accepted
Additional comments about closing:  thanks. in 26409.
Comment by Jonathan Gordon (jdgordon) - Tuesday, 25 May 2010, 02:35 GMT
we are in freeze now, but after 3.6 annoy someone to accept this. alternativly, if you would like to fix it to not hardcode those position numbers that would be great :)
Comment by Chris Savery (csavery) - Tuesday, 25 May 2010, 06:04 GMT
Updated, as suggested. The track info lines are no longer hard coded to position but use the language id instead as lookup.
This makes it easy to add new tags and re-arrange the order of tags.
I've moved composer up to position under artist.
Patch against r26251 and tested on Fuze v2.

Loading...