Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11324 - change view_battery() graph to be curve not bars

Attached to Project: Rockbox
Opened by Marcin Bukat (MarcinBukat) - Friday, 28 May 2010, 13:49 GMT+2
Last edited by Marcin Bukat (MarcinBukat) - Saturday, 17 July 2010, 13:30 GMT+2
Task Type Patches
Category Battery/Charging
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.4
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

   view_battery_graph.patch (1.3 KiB) 
 b/apps/debug_menu.c |   10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

This task depends upon

Closed by  Marcin Bukat (MarcinBukat)
Saturday, 17 July 2010, 13:30 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  commited as r27427
Comment by Rafaël Carré (funman) - Friday, 28 May 2010, 14:06 GMT+2
it looks nice
Comment by Marcin Bukat (MarcinBukat) - Saturday, 29 May 2010, 16:56 GMT+2
A bit more advanced version.
   view_battery_graph_v2.patch (1.7 KiB) 
 b/apps/debug_menu.c |   26 ++++++++++++++++++--------
 1 file changed, 18 insertions(+), 8 deletions(-)

Comment by Marcin Bukat (MarcinBukat) - Saturday, 29 May 2010, 23:29 GMT+2
Graph should be scaled correctly now.
   view_battery_graph_v3.patch (2.6 KiB) 
 b/apps/debug_menu.c |   31 +++++++++++++++++++++----------
 1 file changed, 21 insertions(+), 10 deletions(-)

Comment by Marcin Bukat (MarcinBukat) - Monday, 31 May 2010, 12:16 GMT+2
This one adds horizontal grid.
   view_battery_graph_v4.patch (3.9 KiB) 
 b/apps/debug_menu.c |   64 ++++++++++++++++++++++++++++++++++++++++++----------
 1 file changed, 52 insertions(+), 12 deletions(-)

Comment by Rafaël Carré (funman) - Monday, 31 May 2010, 14:28 GMT+2
Looks fine on Fuze / Clip:
http://img138.imageshack.us/img138/6686/discharging.jpg http://img205.imageshack.us/img205/7193/charging.jpg
Comment by Rafaël Carré (funman) - Monday, 31 May 2010, 14:30 GMT+2
What do you think of showing the grid scale on the screen ? (5 or 50mV)
Comment by Marcin Bukat (MarcinBukat) - Tuesday, 15 June 2010, 23:12 GMT+2
1) Handle small screen sizes
2) Displays grid scale indication
   view_battery_v5.patch (3.8 KiB) 
 b/apps/debug_menu.c |   72 +++++++++++++++++++++++++++++++++++++++++-----------
 1 file changed, 57 insertions(+), 15 deletions(-)

Loading...