Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11433 - Nano 2G: *PANIC* stkov nand crash

Attached to Project: Rockbox
Opened by Hunter Ragnarok (G4Oblivion) - Tuesday, 22 June 2010, 20:05 GMT+2
Last edited by Frank Gevaerts (fg) - Monday, 06 September 2010, 16:14 GMT+2
Task Type Bugs
Category Settings
Status Closed
Assigned To No-one
Player Type iPod Nano 2G
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

When I put these settings into my nano it crashes at "browse themes" it does not crash if I try to change the theme only.

Steps:
Change time format to 12 hour
Playback: Repeat: one, Fade on stop/pause: No
General: LCD brightness = 10, Idle poweroff = 8min., Accessory power supply = No
Theme: Clicking Browse theme files make it crash with "*PANIC* stkov nand" error.

Using revision: r27036

This just started happening. I update quite often and I always do a clean build to reset my settings. I don't like importing my config file.
This task depends upon

Closed by  Frank Gevaerts (fg)
Monday, 06 September 2010, 16:14 GMT+2
Reason for closing:  Fixed
Additional comments about closing:  The final patch was submitted as r28011
Comment by Dominik Riebeling (bluebrother) - Wednesday, 23 June 2010, 07:33 GMT+2
Sounds like the same issue as  FS#11430 . Can you please check if that issue still appears?
Comment by Hunter Ragnarok (G4Oblivion) - Wednesday, 23 June 2010, 18:06 GMT+2
I still get this problem, although its a little different.
Using the same steps + start screen = files.
I was able to change my theme, font, foreground/background color.
I then went to view "files" and I got the same crash, "*PANIC* stkov nand"

I'm guessing its one of the recent updates by theseven that caused it.

I'm currently using r27090
Comment by Hunter Ragnarok (G4Oblivion) - Wednesday, 23 June 2010, 18:10 GMT+2
More information:
I can turn off my nano right after applying the settings then go to view files without crashing.
I was able to turn it off then change the theme before too. Not sure what this means.
Comment by Hunter Ragnarok (G4Oblivion) - Friday, 25 June 2010, 01:57 GMT+2
This has just become a serious problem for me.
I got a clean build put my config file from my previous build and as soon as I turn it on I get the *PANIC* stkov nand.
I would like this fixed since I can't revert back because theres no archived builds for unstable ports......
Comment by Rafaël Carré (funman) - Saturday, 26 June 2010, 00:52 GMT+2
Give a try to FS#11429 instead of complaining, we all want that fixed.
Comment by Hunter Ragnarok (G4Oblivion) - Tuesday, 31 August 2010, 06:24 GMT+2
I've built the latest release (r27956) and did a temporary fix on it to stop the crash. You can download it here http://www.mediafire.com/?2m2ql9atvp9q4q4
I'll post a .diff of what I did. All I did was remove "call_storage_idle_notifys(false);"
   nand.patch (0.5 KiB) 
 firmware/target/arm/s5l8700/ipodnano2g/nand-nano2g.c |    3 ---
 1 file changed, 3 deletions(-)

Comment by Frank Gevaerts (fg) - Sunday, 05 September 2010, 14:50 GMT+2
This patch changes fat.c a bit to avoid ever allocating two sector buffers on the stack. From what I can see, that should make things work without changing nand_stack, or at least without changing it a lot.
   fat_stack.diff (2.5 KiB) 
 firmware/drivers/fat.c |   31 ++++++++++++++++++++++---------
 1 file changed, 22 insertions(+), 9 deletions(-)

Comment by Frank Gevaerts (fg) - Sunday, 05 September 2010, 19:06 GMT+2
This patch should make sure that fat.c never allocates more than one sector buffer on the stack
   fat_stack_v2.diff (5.5 KiB) 
 firmware/drivers/fat.c |   66 ++++++++++++++++++++++++++++++++++---------------
 1 file changed, 47 insertions(+), 19 deletions(-)

Comment by Hunter Ragnarok (G4Oblivion) - Monday, 06 September 2010, 02:13 GMT+2
Thanks Gevaerts!, I have not gotten the nand crash yet. All I tested was my normal "Import config.cfg and wait for crash".
I will try to test it some more, but I think its fine.
Comment by Hunter Ragnarok (G4Oblivion) - Monday, 06 September 2010, 13:19 GMT+2
I did some more testing and could not get the "*PANIC* stkov nand" crash.
Small plus; when opening and closing a text file main stack usage went from 75% to 62%.

Little annoying that just by removing "call_storage_idle_notifys(false);" nand stack usage goes from 74% to 2%.

Is this something that could make it into current svn? or would it interfere with other targets?
Sorry, I don't know much about coding.
Comment by Frank Gevaerts (fg) - Monday, 06 September 2010, 13:28 GMT+2
Removing call_storage_idle_notifys() removes a large part of the reason why the nand thread (and stack) exists, so it's not surprising that that reduces stack usage.

Yes, this is meant for svn, it just needs a bit more testing (possibly on other targets too) to make sure it doesn't break anything.

Loading...