Rockbox

Tasklist

FS#11462 - Philips GoGear HDD63x0 patch to disable / enable backlight

Attached to Project: Rockbox
Opened by David Fowle (dtr) - Wednesday, 07 July 2010, 07:18 GMT
Last edited by Szymon Dziok (b0hoon) - Monday, 18 October 2010, 20:09 GMT
Task Type Patches
Category LCD
Status Closed
Assigned To No-one
Operating System Another
Severity Low
Priority Normal
Reported Version Release 3.6
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

The current code only sets the backlight to the lowest setting. This patch actually turns the backlight off when the timeout occurs.
This task depends upon

Closed by  Szymon Dziok (b0hoon)
Monday, 18 October 2010, 20:09 GMT
Reason for closing:  Accepted
Additional comments about closing:  Commited in r28307. Thanks!
Comment by Rafaël Carré (funman) - Friday, 09 July 2010, 20:29 GMT
What happens on the other philips?

Does the backlight work correctly on them or is it set to the lowest setting too?
Comment by David Fowle (dtr) - Saturday, 10 July 2010, 03:38 GMT
The altered file is only used by the philips hdd63x0 and hdd16x0 targets. I cannot comment on the current functionality of the backlight for the hdd16x0 as I do not own one. My assumption was that the code was correct for the hdd16x0 and as such, the patch only changes functionality for the hdd63x0.
Comment by Maximilian Belz (mx03) - Tuesday, 21 September 2010, 19:27 GMT
I use HDD1620 and when the backlight timeout occurs, the lcd blinks a little. (Turn backlights on, off, on, off, ...)
Maybe this patch solves the problem, if i have time to compile i try it.
Comment by Szymon Dziok (b0hoon) - Thursday, 07 October 2010, 10:34 GMT
I'm not sure if this method is correct at all. I must look into OF and find it.

EDIT: Found it. Solution is correct, OF does it the same way but always with GPO32_ENABLE |= 0x400 before GPO32_VAL.

mx03: This patch has no influence on HDD16x0 at all.

Loading...