Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11473 - New bookmarking option: one per track

Attached to Project: Rockbox
Opened by Alexander Levin (fml2) - Monday, 12 July 2010, 22:43 GMT+2
Task Type Patches
Category Settings
Status New
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.6
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Private No

Details

This patch implements the idea proposed and discussed in http://forums.rockbox.org/index.php?topic=24952.0

It adds a new option of how to create and maintain the list of the recent bookmarks (MRB): one per track. With this option, if a bookmark is added to the MRB, other bookmarks from the same playlist and the same track are not retained.

Comments are welcome.

I think it would be good if we could introduce such option for "normal" bookmark files too, i.e. to store only one bookmark per track in a bookmark list. But this would be matter of a separate patch.
   bm_per_track.diff (7.6 KiB) 
 apps/lang/english.lang                   |   36 +++++++++++++++---
 apps/settings.h                          |    9 +++-
 apps/settings_list.c                     |    5 +-
 apps/bookmark.c                          |   61 +++++++++++++++++++++++--------
 manual/configure_rockbox/bookmarking.tex |    9 +++-
 5 files changed, 93 insertions(+), 27 deletions(-)

This task depends upon

Comment by Alexander Levin (fml2) - Tuesday, 13 July 2010, 18:51 GMT+2
The new patch also updates the manual section with config file options.
   bm_per_track2.diff (8.3 KiB) 
 apps/lang/english.lang                   |   36 +++++++++++++++---
 apps/settings.h                          |    9 +++-
 apps/settings_list.c                     |    5 +-
 apps/bookmark.c                          |   61 +++++++++++++++++++++++--------
 manual/appendix/config_file_options.tex  |    2 -
 manual/configure_rockbox/bookmarking.tex |    9 +++-
 6 files changed, 94 insertions(+), 28 deletions(-)

Comment by Alexander Levin (fml2) - Wednesday, 14 July 2010, 23:33 GMT+2
Bin and RAM sizes for Sansa e200 v1 (target build):

Unpatched:
Version: r27423-100714
Binary size: 585728
Actual size: 584724
RAM usage: 1522048

Patched:
Version: r27423M-100714
Binary size: 585728 (+0)
Actual size: 584940 (+216)
RAM usage: 1522272 (+224)
Comment by Alexander Levin (fml2) - Wednesday, 14 July 2010, 23:56 GMT+2
Get rid of a compile warning in bookmark.c (possibly uninitialized variable)
   bm_track3.diff (8.3 KiB) 
 apps/lang/english.lang                   |   36 +++++++++++++++---
 apps/settings.h                          |    9 +++-
 apps/settings_list.c                     |    5 +-
 apps/bookmark.c                          |   61 +++++++++++++++++++++++--------
 manual/appendix/config_file_options.tex  |    2 -
 manual/configure_rockbox/bookmarking.tex |    9 +++-
 6 files changed, 94 insertions(+), 28 deletions(-)

Comment by Marek Salaba (salaba) - Saturday, 21 August 2010, 14:43 GMT+2
It is very usefull function.
Salaba
Comment by AJ Thorton (ajthorton) - Friday, 10 September 2010, 00:50 GMT+2
I love this! Very useful.

Loading...