Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11475 - Adding hardware keyclick to Ipod Color.

Attached to Project: Rockbox
Opened by pirlouwi (pirlouwi) - Tuesday, 13 July 2010, 21:18 GMT+2
Last edited by Robert Menes (RMenes379) - Wednesday, 14 December 2011, 16:13 GMT+2
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Player Type iPod 4G Color
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch is to add hardware keyclick to Ipod Color, and apply on apps/action.c revision 27409.
This should also work for further Ipod hardwares, but I
could only test my patch on my own Ipod Color.
PS: this code was extracted from the Ipodlinux bootloader.
--
pirlouwi
   action.c.patch (1.8 KiB) 
 apps/action.c |   36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

This task depends upon

Closed by  Robert Menes (RMenes379)
Wednesday, 14 December 2011, 16:13 GMT+2
Reason for closing:  Out of Date
Additional comments about closing:   FS#5111  does the same thing for all iPods.
Comment by MichaelGiacomelli (saratoga) - Tuesday, 13 July 2010, 22:21 GMT+2
You should not put a piezo driver in the apps folder. It should go in firmware with the rest of the ipod drivers.

Take a look at  FS#5111 . Its the same thing, except much further along.

Comment by Hayden Pearce (St.) - Wednesday, 14 July 2010, 14:54 GMT+2
If you made this available to more than simply the iPod Video (iPod Nano1G or 2G preferably) I would definitely be interested in testing it.
A while ago I synced the piezo patch at  FS#5111 , but only the Nano2G functions as expected.
It compiles fine for the other iPod models, but there's not a "click" to be heard.
Perhaps you're the man to look at what is broken in this patch ( FS#5111 )? It's beyond my ability to do so.


[St.]
Comment by pirlouwi (pirlouwi) - Wednesday, 14 July 2010, 17:10 GMT+2
My patch is uggly, but functional, just for testing. As Michael said here, I must put hardware-related functions into the firmware folder.
The  FS#5111  patch is by far more complex. This is also the reason why it is broken.
It depends what we want as functionalities.
For the moment, my patch has bind the keyclick in the earbuds with the hardware keyclick, so that if you enabled the earbuds keyclick you automatically get the hardware keyclick.
I think that it could be acceptable, at least for myself.
For the community, I don't know.
If I try to add an entry in the configuration menu, then the patch will grows and after two years, will certainly become unstable :-)
Comment by pirlouwi (pirlouwi) - Wednesday, 14 July 2010, 17:20 GMT+2
As concerns  FS#5111 , I could only test for iPod Color.

Loading...