Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11490 - Update for CabbieV2 WPS

Attached to Project: Rockbox
Opened by Hayden Pearce (St.) - Monday, 19 July 2010, 13:56 GMT+1
Last edited by Michael Chicoine (mc2739) - Saturday, 20 August 2011, 03:12 GMT+1
Task Type Patches
Category Themes
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

I have updated some (for now, more to come) of the CabbieV2 WPS:

- To use viewports for all cases of images and text.
- Broken the WPS code into sections instead of one huge chunk
- Lightly commented the WPS code
- Arranged the code to be consistent between each of the targets
- Use a consistent header for each file
- Fixed some coding errors (no functional changes)

I intend to finish the remaining targets in the very near future.

In this patch:

- iAudio X5
- iPod Nano 1G
- iPod Nano 2G
- iPod Color/Photo
- iPod Video
- iRiver H10 5/6 GB
- iRiver H10 20 GB
- iRiver H320
- iRiver H340
- Packard Bell Vibe 500
- Sansa c200 Series

[St.]
   Update CabbieV2.patch (15.7 KiB) 
 wps/cabbiev2.132x80x16.wps  |   71 ++++++++++++++++++++++++++---------
 wps/cabbiev2.320x240x16.wps |   83 +++++++++++++++++++++++++++++------------
 wps/cabbiev2.220x176x16.wps |   75 +++++++++++++++++++++++++++----------
 wps/cabbiev2.160x128x16.wps |   75 +++++++++++++++++++++++++++----------
 wps/cabbiev2.176x132x16.wps |   75 +++++++++++++++++++++++++++----------
 wps/cabbiev2.128x128x16.wps |   88 ++++++++++++++++++++++++++++++--------------
 6 files changed, 333 insertions(+), 134 deletions(-)

This task depends upon

Closed by  Michael Chicoine (mc2739)
Saturday, 20 August 2011, 03:12 GMT+1
Reason for closing:  Out of Date
Comment by Hayden Pearce (St.) - Monday, 19 July 2010, 20:01 GMT+1
But wait, there's more.

- Added a few of the greyscale targets also
- Additional cleanup


[St.]
   FS#11490 - Update for CabbieV2 WPS.patch (21.3 KiB) 
 wps/cabbiev2.132x80x16.wps  |   67 +++++++++++++++++++++++++--------
 wps/cabbiev2.320x240x16.wps |   79 ++++++++++++++++++++++++++++-----------
 wps/cabbiev2.220x176x16.wps |   75 +++++++++++++++++++++++++++----------
 wps/cabbiev2.138x110x2.wps  |   75 +++++++++++++++++++++++++++----------
 wps/cabbiev2.160x128x2.wps  |   76 +++++++++++++++++++++++++++-----------
 wps/cabbiev2.128x128x2.wps  |   88 ++++++++++++++++++++++++++++++--------------
 wps/cabbiev2.160x128x16.wps |   75 +++++++++++++++++++++++++++----------
 wps/cabbiev2.176x132x16.wps |   71 ++++++++++++++++++++++++++---------
 wps/cabbiev2.128x128x16.wps |   84 +++++++++++++++++++++++++++++-------------
 9 files changed, 495 insertions(+), 195 deletions(-)

Comment by Jonathan Gordon (jdgordon) - Monday, 26 July 2010, 14:08 GMT+1
Done... now the last few?
I'll leave the task open incase anyone wants to mention a mistake...
Comment by Hayden Pearce (St.) - Monday, 26 July 2010, 18:51 GMT+1
Like this one ;)

Silly little one char error to fix "Hold" on the Video
   FS#11490 - [Fix 320x240x16 Hold].patch (0.3 KiB) 
 wps/cabbiev2.320x240x16.wps |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comment by Nils Wallménius (nls) - Wednesday, 28 July 2010, 11:38 GMT+1
The c200 cabbiev2 wps now fails to load with:
ERR: Failed parsing on line 39 : ERR: Invalid parameter list for token 81: "No token"
Comment by Michael Chicoine (mc2739) - Wednesday, 18 August 2010, 18:18 GMT+1
I reopened this task since not all targets have have been updated.

The following still need updating:

no viewports/comments
cabbiev2.160x128x1

partial viewports/comments
cabbiev2.240x400x16

patches attached below - not committed
cabbiev2.112x64x1
cabbiev2.128x64x1
cabbiev2.128x96x2
cabbiev2.176x220x16
cabbiev2.240x320x16

other
cabbiev2.240x320x16.mini2440 - sim will not build
cabbiev2.320x240x16.mrobe500 - mrobe500 does not use this (screen set to 640x480x16)

Preferably, the commenting/layout style should be similar to the ones that have been updated so far.
Comment by Michael Chicoine (mc2739) - Thursday, 19 August 2010, 00:19 GMT+1
Here are the updates for cabbiev2.176x220x16, cabbiev2.240x320x16, cabbiev2.112x64x1, cabbiev2.128x64x1 and cabbiev2.128x96x2
   cabbiev2.176x220x16.patch (2.5 KiB) 
 wps/cabbiev2.176x220x16.wps |   85 +++++++++++++++++++++++++++++++-------------
 1 file changed, 61 insertions(+), 24 deletions(-)

   cabbiev2.240x320x16.patch (2.9 KiB) 
 wps/cabbiev2.240x320x16.wps |   97 +++++++++++++++++++++++++++++++-------------
 1 file changed, 69 insertions(+), 28 deletions(-)

   cabbiev2.112x64x1.patch (2 KiB) 
 wps/cabbiev2.112x64x1.wps |   58 ++++++++++++++++++++++++++++++++++------------
 1 file changed, 43 insertions(+), 15 deletions(-)

   cabbiev2.128x64x1.patch (2.3 KiB) 
 wps/cabbiev2.128x64x1.wps |   79 +++++++++++++++++++++++++++++-----------------
 1 file changed, 50 insertions(+), 29 deletions(-)

   cabbiev2.128x96x2.patch (2 KiB) 
 wps/cabbiev2.128x96x2.wps |   61 ++++++++++++++++++++++++++++++++--------------
 1 file changed, 43 insertions(+), 18 deletions(-)

Comment by Michael Chicoine (mc2739) - Sunday, 22 August 2010, 01:44 GMT+1
The patches above were committed with r27856

The following still need updating:

no viewports/comments
cabbiev2.160x128x1

partial viewports/comments
cabbiev2.240x400x16

Loading...