Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11546 - Adjustable brightness in lamp plugin

Attached to Project: Rockbox
Opened by Calvin Walden (clone4crw) - Monday, 16 August 2010, 20:52 GMT+2
Last edited by Teruaki Kawashima (teru) - Saturday, 06 November 2010, 14:46 GMT+2
Task Type Patches
Category Plugins
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Here's a small patch I wrote that adds the ability to adjust the brightness of the lamp plugin. It uses the NEXT/PREV keys that would normally duplicate the functionality of LEFT/RIGHT to cycle through the colors.

It was made for the Sansa e200 and Fuze, where NEXT/PREV are mapped to the scroll wheel.

Created in daily build 100816.
   lamp_brightness.diff (2 KiB) 
 apps/plugins/lamp.c |   20 ++++++++++++++++----
 1 file changed, 16 insertions(+), 4 deletions(-)

This task depends upon

Closed by  Teruaki Kawashima (teru)
Saturday, 06 November 2010, 14:46 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  commited as r28519
Comment by Rafaël Carré (funman) - Sunday, 22 August 2010, 21:51 GMT+2
Please remove the tabs and change the manual accordingly

If you need help with the manual ask pixelma on IRC
Comment by Thomas Martitz (kugel.) - Sunday, 22 August 2010, 21:52 GMT+2
The purpose of lamp is to give light in dark situations, I don't see how lowering the brightness adds anything to that.
Comment by Calvin Walden (clone4crw) - Sunday, 22 August 2010, 21:56 GMT+2
Here is a revised version, with tab characters replaced by spaces
   lamp_brightness_2.diff (2.1 KiB) 
 apps/plugins/lamp.c |   20 ++++++++++++++++----
 1 file changed, 16 insertions(+), 4 deletions(-)

Comment by Calvin Walden (clone4crw) - Sunday, 22 August 2010, 21:58 GMT+2
I get that the purpose is provide light, but often times the backlight at full brightness is often hard on the eyes at night, and is often unnecessary when combined with the wheel light of the Sansa.
Comment by Teruaki Kawashima (teru) - Tuesday, 02 November 2010, 14:22 GMT+2
re-implement this...
- add the functionality for all possible targets.
- add button table to the manual.
   lamp_brightness_3.diff (7.2 KiB) 
 apps/plugins/lamp.c     |  101 +++++++++++++++++++++++++++++-------------------
 manual/plugins/lamp.tex |   17 +++++++-
 2 files changed, 78 insertions(+), 40 deletions(-)

Comment by Thomas Martitz (kugel.) - Tuesday, 02 November 2010, 14:24 GMT+2
I still don't see the point but if you want it so much commit it already :)

Loading...