This is the bug/patch tracker for Rockbox. Click here for more information.
Quick links: Bugs · Patches · Rockbox frontpage
FS#11550 - %x() image "drawn below" %pb() in the same viewport doesn't show up
Attached to Project:
Rockbox
Opened by Andrew Freedgood (kaiscene) - Wednesday, 18 August 2010, 07:54 GMT+2
Last edited by Jonathan Gordon (jdgordon) - Saturday, 09 October 2010, 12:02 GMT+2
Opened by Andrew Freedgood (kaiscene) - Wednesday, 18 August 2010, 07:54 GMT+2
Last edited by Jonathan Gordon (jdgordon) - Saturday, 09 October 2010, 12:02 GMT+2
|
DetailsBuild: r27821
Player Type: Sansa Clip+ Description: Prior to r27821 (changes to the %pb() tag), the following WPS code would display both "pbbackground.bmp" and the progress bar in the same location on the screen. The progressbar would appear "on top" of the background image. [....] %V(0,0,-,8,2) %x(a,pbbackground.bmp,32,0) %pb(32,0,66,6,pb.bmp) r27821 causes the %x() image to not display at all. Maybe the progressbar is completely covering it? Workarounds: *(1) when rockbox starts up it, it automatically loads the theme and the %x() is not displayed. (2) load any other wps. (3) load the original wps from (1), and the %x() image shows up. *Adding a syntactically-unnecessary %xd() does fix the problem without resorting to reloading the theme. [....] %V(0,0,-,8,2) %x(a,pbbackground.bmp,32,0) %xd(a) %pb(32,0,66,6,pb.bmp) The full theme is attached, which includes the images pbbackground.bmp and pb.bmp. 
U-YellowBarDynamic.zip
(2.5 KiB)
|
This task depends upon
Closed by Jonathan Gordon (jdgordon)
Saturday, 09 October 2010, 12:02 GMT+2
Reason for closing: Fixed
Additional comments about closing: r28184
Saturday, 09 October 2010, 12:02 GMT+2
Reason for closing: Fixed
Additional comments about closing: r28184
A viewport consisting of only the %x() tag fails to display the %x() image.
Example:
%V(0,0,-,8,2)
%x(a,pbbackground.bmp,32,0)
# will show nothing
%V(0,0,-,8,2)
%x(a,pbbackground.bmp,32,0)
%xd(a)
# shows the image.
r27771, r27780, r27785 and r27786 all showed the picture with %x(a,a.bmp,0,0) just fine.
Workaround for now is to use %xl(a,a.bmp,0,0)%xd(a) instead.
As Andrew already commented, this has nothing to do with %pb. Just %x is broken. Sometimes the picture is drawn completely, sometimes incompletely (looks like noise in my case) and sometimes not at all.
Just checked again. Put r27786 on the player, selected the wps file with only
%V(0,95,-,16,1)
%x(a,a.bmp,0,0)
went to wps, image was shown. rebooted, continued playback, image was shown. rebooted again, continued playback, image was shown.
Now put r27787 with that same wps file on the player. Selected the wps file, went to wps, image was shown. rebooted, continued playback, no image.
I'll have a look at the changes made in r27787 now. Maybe I can help you to narrow down where the problem comes from.
1004 if (img->using_preloaded_icons)
1005 {
1006 img->loaded = true;
1007 list->token->type = SKIN_TOKEN_IMAGE_DISPLAY_LISTICON;
1008 }
1009 else
1010 {
and
1017 }
in r27787 makes %x working.
umm... have you got it going in gdb there? is img->using_preloaded_icons true there? it shouldnt be
No I didn't use any debugger. Can I even do it in the player without special equipment?
img->using_preloaded_icons = false;
before the line
if(img->using_preloaded_icons)
it works as well.
So yes, using_preloaded_icons is indeed true there!! And this only happens on boot, so maybe the simulator 'boots' differently?
But it does happen on multiple targets (see that the original poster used a clipplus).
i think the bug is fixed by r28184.