Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11564 - new tag to talk other tags

Attached to Project: Rockbox
Opened by Jonathan Gordon (jdgordon) - Monday, 23 August 2010, 15:02 GMT+2
Last edited by Jonathan Gordon (jdgordon) - Tuesday, 24 August 2010, 02:39 GMT+2
Task Type Patches
Category Themes
Status New
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.6
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Private No

Details

This patch reimplements FS#11541 using the skin engine.

new skin tag %Vx(params) will talk whatever is in the params (unlimited....)..
Params can be any string or other skin tag (no conditionals just yet).
if the first option is - it will shutup anything currently talking. otherwise - is a voiced pause.
otherwise the only special string is the word "text" which says to spell the next tag (used when the value of the tag is usable in a conditional, i.e %cP need talk or you will get "1" or "2" :/ ).

quick examples:
%?mh<%Vx(-, %cl,-, %cM, text, %cP)> <- Talk the current hour, minute, am/pm when hold is toggled.

%?pE(15)<%?It<%Tx(-, %Ia, -, %It)>> <- untested but should spell the next tracks title and artist when there is 15s left of the current track
   voicewps.diff (5.5 KiB) 
 b/apps/gui/skin_engine/skin_parser.c |    3 ++
 b/apps/gui/skin_engine/skin_render.c |   51 +++++++++++++++++++++++++++++++++++
 b/lib/skin_parser/skin_parser.c      |   10 ++++++
 b/lib/skin_parser/tag_table.c        |    3 ++
 b/lib/skin_parser/tag_table.h        |    2 +
 5 files changed, 68 insertions(+), 1 deletion(-)

This task depends upon

Comment by alex wallis (alexwallis646) - Monday, 23 August 2010, 17:31 GMT+2
hi, I think you linked to the wrong patch didn't you?

the one you linked to is something to do with track skipping.

To be honest, I looked at the tags, and it all looked very complicated and not at all easy to understand. Also, they include a lot of punctuation which is obviously extremely important in the wps, but meant I had to arrow through individual letters to read it, and also that it just wasn't very readable.

I read the example tags, and couldn't even hazard a guess at understanding what they would voice.
from a simplicity point of view I prefer
fs#11541 as I wouldn't feel confident about working with the wps tags.

Of course it would be good if the wps eventually does get voiced but I wouldn't feel confident about making changes as at least in my opinion the tags are not very human readable or easy to work with.
Comment by alex wallis (alexwallis646) - Monday, 23 August 2010, 20:45 GMT+2
sorry, just reread my above comment, to clarify I meant I wouldn't be able to guess at what they would do if you hadn't explained what they do. From a newbies point of view, working with the tags looks very complicated and intimidating.
Comment by Jonathan Gordon (jdgordon) - Tuesday, 24 August 2010, 02:41 GMT+2
Like I said in the other patch, this one isnt about accessibility but as a general talking system which the other one could be built on.

Loading...