Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11573 - Cabbiev3 doesn't show progress bar and album art in current build

Attached to Project: Rockbox
Opened by Matteo Italia (MItaly) - Thursday, 26 August 2010, 21:32 GMT+2
Last edited by Jonathan Gordon (jdgordon) - Friday, 03 September 2010, 02:27 GMT+2
Task Type Bugs
Category Themes
Status Closed
Assigned To No-one
Player Type Another
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

As specified in the summary, the (IMO) great theme Cabbiev3 presents several problems with the current build, because, as it is, it doesn't use separate viewports for the progress bar and the album art.

Here's a fix for the 220x176 color targets version. I also removed the empty line between the album name and the next track label to make the theme more big-fonts friendly.
I'm not sure of having done everything correctly (it's the first time I edit themes), but it seems to work fine in the sim.
   cabbiev3.patch (0.5 KiB) 
 unknown |   15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Friday, 03 September 2010, 02:27 GMT+2
Reason for closing:  Invalid
Additional comments about closing:  theme fixes (except for the ones shipped in rockbox.zip) dont belong here
Comment by Matteo Italia (MItaly) - Thursday, 26 August 2010, 21:33 GMT+2
Forgot to say, the patch has to be applied to cabbiev3.wps.
Comment by Hayden Pearce (St.) - Saturday, 28 August 2010, 05:05 GMT+2
My suggestion would be to leave a note with the original author of the theme.
Authors *should* have been more than aware of the syntax/parser change(s) and all that went with it.


[St.]
Comment by Matteo Italia (MItaly) - Saturday, 28 August 2010, 16:00 GMT+2
Yes, you're right, I'll send him an e-mail.
Comment by Matteo Italia (MItaly) - Saturday, 28 August 2010, 20:58 GMT+2
Fixed also the localization issue of the "Next:" label. Here I provide the diff (a working one, I hope, now :S ) and the complete file, which, for such a small file, may be more convenient.
   cabbiev3.wps (2 KiB)
   cabbiev3.wps.diff (1.6 KiB) 
 cabbiev3.wps |   17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

Loading...