Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11606 - ACTION_TREE_STOP stops radio too

Attached to Project: Rockbox
Opened by Michael Gentry (Confuseling) - Monday, 06 September 2010, 14:11 GMT+2
Last edited by Nils Wallménius (nls) - Sunday, 17 October 2010, 10:48 GMT+2
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.6
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Rationale:
To my mind it is more consistent - at the moment, you are in the WPS, you press the menu key, then the ACTION_TREE_STOP key, and your music stops. You are in the radio, you press the same, and nothing happens.

Implementation:
Obviously, this is trivial in extremis, but I'm no coder... I've included radio.h, and added a call to radio_stop() in list_stop_handler(), in misc.c. Both changes are behind ifdef CONFIG_TUNERs. This is guesswork, and might be horribly wrong, but it seems to work on a Sansa Clip+. I tried turning off CONFIG_TUNER to test it, but that results in all kinds of oddness, and I don't think it's because of this patch.

Built against 27999.
   list.stop.radio.patch (0.5 KiB) 
 apps/misc.c |    8 ++++++++
 1 file changed, 8 insertions(+)

This task depends upon

Closed by  Nils Wallménius (nls)
Sunday, 17 October 2010, 10:48 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  comiitted, thanks
Comment by Michael Gentry (Confuseling) - Monday, 06 September 2010, 16:05 GMT+2
Also, thanks to JdGordon for the advice.

Loading...