This is the bug/patch tracker for Rockbox. Click here for more information.
Quick links: Bugs · Patches · Rockbox frontpage
FS#11613 - skin backdrop loaded is broken
Attached to Project:
Rockbox
Opened by Jonathan Gordon (jdgordon) - Tuesday, 07 September 2010, 15:22 GMT+2
Last edited by Jonathan Gordon (jdgordon) - Wednesday, 15 September 2010, 12:33 GMT+2
Opened by Jonathan Gordon (jdgordon) - Tuesday, 07 September 2010, 15:22 GMT+2
Last edited by Jonathan Gordon (jdgordon) - Wednesday, 15 September 2010, 12:33 GMT+2
|
Detailsif a skin doesnt specify a backdrop (so the setting is used) and that skin fails to load the hardcoded skin will try to use the same backdrop (and will be then given an invalid pointer by skin_backdrop_load() which ends up with totaly garbed backdrop image.
This is probaly only viewable with a broken .sbs being loaded becase the hardcoded wps uses %X(d) whereas the hardcoded sbs doesnt. possible fix is work this in with the skin manager so skins backdrops are checked for validity on use. Alternativly (and maybe additionally) load backdrops later so we will be able to tell when a theme uses too much space because a backdrop will not be displayed instead of it appearing to fail to parse. |
This task depends upon
Closed by Jonathan Gordon (jdgordon)
Wednesday, 15 September 2010, 12:33 GMT+2
Reason for closing: Fixed
Wednesday, 15 September 2010, 12:33 GMT+2
Reason for closing: Fixed