Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Playlists
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.6
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by fg - 2010-09-26
Last edited by fg - 2012-01-24

FS#11644 - Playlist isn't loaded after reboot if it had ended

The current playlist isn’t loaded after reboot if it had ended. This makes things like “View Current Playlist” and “Save Current Playlist” behave differently after the end of a playlist if the player is rebooted. I think all such inconsistencies shoud be removed.

Note that with e.g. in-car use, the user may not even realise whether the DAP was rebooted or not, since it will power up automatically.

This patch changes that, so the current playlist is *always* reloaded.

Please review, I’m not a playback/playlist expert

   resume.diff (1 KiB)
Closed by  fg
2012-01-24 22:16
Reason for closing:  Out of Date
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

In current code the playlist viewer isn't accessible any more after the playlist ends, which means that the entire issue is moot.

asettico commented on 2010-11-15 16:08

I can’t see the difference in behaviour between this and FS#10343 or, at least, I see this one as a subset of that one.

sideral commented on 2011-07-05 13:32

assetico, the two patches are completely orthogonal, AFAIU. This patch restores a completed playlist after a reboot so that it can be inspected with the playlist editor, whereas FS#10343 allows restarting a completed playlist using the Resume playback function in the main menu instead of showing the “nothing to resume” splash.

asettico commented on 2011-07-05 13:45

OK, now is more clear.
When I read “restore” I understand “load and play”.
Thanks for the precise information.

St. commented on 2011-08-05 01:33

Committed in r30226 and later reverted in r30232 due to this bug:

With this patch applied, dynamic playlists aren’t blown away when inserting (a) track(s) with playback stopped. This makes it impossible to clear the dynamic playlist as all inserted tracks are appended to the current list instead of starting anew.

Recipe:

With this patch applied, insert some tracks into a dynamic playlist.
Stop playback.
Insert some tracks either from the Database or Filebrowser, these tracks are appended to the previous stopped dynamic playlist instead of starting a new dynamic playlist.

[St.]

MikeS commented on 2012-01-24 20:54

What current playlist? There is no current playlist. After it ends, it’s done; that’s it. Seems like something conceptually distinct from a “current playlist” in a “now playing” sense.

Admin
fg commented on 2012-01-24 21:03

If you don’t reboot, there is still something there, and the UI calls it the current playlist.

MikeS commented on 2012-01-24 21:59

Menu items seem to be gone now.

Anyway, I’d either consider “end of playlist” to rid the system of the current playlist or always retain the previous one, either in memory or in persistent storage. If marked as completed, playlist edit commands should clear it properly, or always give a set of options. Appearance of “Erase dynamic playlist?” isn’t even consistent between using directories and the database.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing