Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11682 - disktidy plugin does not clean custom files.

Attached to Project: Rockbox
Opened by flan_suse (flan_suse) - Sunday, 17 October 2010, 06:42 GMT+2
Last edited by Robert Menes (RMenes379) - Sunday, 31 October 2010, 14:06 GMT+2
Task Type Bugs
Category Plugins
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Daily build: r28294-101016

This disktidy plugin will not delete files that were added under "Other" when added as a custom entry.

I edited disktidy.config and added a custom string that I wish to be cleaned out. Here is an example:

# Disktidy config
# When adding a new file, make sure its NOT enabled
< ALL >: no
< NONE >: no
< Windows >: no
desktop.ini: no
Thumbs.db: no
Recycled/: no
$RECYCLE.BIN/: no
System Volume Information/: no
< Mac OSX >: no
.Trashes/: no
.DS_Store: no
._*: no
< Linux/BSD >: no
.Trash-*/: no
.dolphinview: no
.d3lphinview: no
< Other >: no
*.bmark: no

As you can see, I want the plugin to clean out all of my bookmarks. In Rockbox, I enable the bottom entry. When I launch the cleaner, it says "0 files cleaned", and all my .bmark files remain untouched.
This task depends upon

Closed by  Robert Menes (RMenes379)
Sunday, 31 October 2010, 14:06 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Committed as r28414.
Comment by amaury pouly (pamaury) - Sunday, 17 October 2010, 12:17 GMT+2
I might be wrong but iirc, you can only put a * at the end of the file. For example:
._*
.Trash-*/

Perhaps someone who knows the plugin better than me can have a look. I guess it wouldn't be too hard to implement support for * at the begining.
Comment by Teruaki Kawashima (teru) - Sunday, 17 October 2010, 13:28 GMT+2
here is a patch to allow a * at the end or begining.
these will work.
*xyz
xyz*
xyz*/

these don't work
x*z
*xyz*
   disktidy.patch (1.9 KiB) 
 apps/plugins/disktidy.c |   21 +++++++++++++++------
 1 file changed, 15 insertions(+), 6 deletions(-)

Comment by Teruaki Kawashima (teru) - Monday, 18 October 2010, 14:10 GMT+2
here is another patch, which allos up to one * in filestring. "xyz*", "*xyz", and "x*z" will work.
   disktidy.patch (2.9 KiB) 
 apps/plugins/disktidy.c |   51 ++++++++++++++++++++++++++++++++++--------------
 1 file changed, 37 insertions(+), 14 deletions(-)

Comment by flan_suse (flan_suse) - Monday, 18 October 2010, 14:53 GMT+2
Maybe a disclaimer should be included with the default disktidy.config file, to warn users that custom strings can be dangerous and could lead to data loss? I just realized the risk involved from a simple typo in the config file.

Maybe something like:

# Disktidy config
# When adding a new file, make sure its NOT enabled
# Use extreme caution with custom entries, as you could accidentally delete important files
Comment by Teruaki Kawashima (teru) - Thursday, 28 October 2010, 12:57 GMT+2
it sounds good idea. added to patch.
also, updated the manual entry including the warning.
   disktidy.patch (4.1 KiB) 
 apps/plugins/disktidy.config |    2 +
 apps/plugins/disktidy.c      |   51 +++++++++++++++++++++++++++++++------------
 manual/plugins/disktidy.tex  |    6 +++++
 3 files changed, 45 insertions(+), 14 deletions(-)

Loading...