Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11708 - Android yesno screen improvements

Attached to Project: Rockbox
Opened by Thomas Martitz (kugel.) - Sunday, 31 October 2010, 23:17 GMT+2
Last edited by Thomas Martitz (kugel.) - Saturday, 06 November 2010, 02:41 GMT+2
Task Type Patches
Category Battery/Charging
Status Closed
Assigned To No-one
Player Type Another
Severity Low
Priority Normal
Reported Version Release 3.6
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

The first uses wakeup_wait() instead of polling for waiting for the YesnoActivity result.
The second uses our lang strings for yes and no on the buttons in the dialog.
   0001-Proof-of-concept-yesno-with-wakeup_wait.patch (5.3 KiB) 
 b/android/src/org/rockbox/RockboxYesno.java |   35 +++++-----------------------
 b/apps/hosted/yesno.c                       |   34 ++++++++++++++-------------
 b/firmware/export/config.h                  |    3 +-
 3 files changed, 27 insertions(+), 45 deletions(-)

   0002-Android-Localize-yes-no-text-on-the-buttons-... (3.8 KiB) 
 b/android/src/org/rockbox/RockboxYesno.java  |    4 +++-
 b/android/src/org/rockbox/YesnoActivity.java |    4 ++--
 b/apps/hosted/yesno.c                        |    8 ++++++--
 3 files changed, 11 insertions(+), 5 deletions(-)

This task depends upon

Closed by  Thomas Martitz (kugel.)
Saturday, 06 November 2010, 02:41 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  r28512 and r28515

Loading...