Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11711 - WPS Hotkey: Create bookmark

Attached to Project: Rockbox
Opened by Michael Gentry (Confuseling) - Monday, 01 November 2010, 19:47 GMT+2
Task Type Patches
Category User Interface
Status Unconfirmed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Private No

Details

This patch simply adds a 'Create bookmark' option to the WPS hotkey, calling bookmark_create_menu

Built against r28432.

Thanks to Torne for advice, and Seani whose patch (11541) helped me figure out how to do this.
   hotkey_bookmark.patch (1.7 KiB) 
 apps/onplay.c        |    3 +++
 apps/onplay.h        |    1 +
 apps/settings_list.c |    4 ++--
 3 files changed, 6 insertions(+), 2 deletions(-)

This task depends upon

Comment by Jeffrey Goode (Blue_Dude) - Monday, 08 November 2010, 17:26 GMT+2
At first glance this looks like it would work, but I would recommend not inserting HOTKEY_BOOKMARK into the middle of the enum. Put it at the end instead. This ensures that you don't break backward compatibility with user settings.
Comment by Michael Gentry (Confuseling) - Tuesday, 09 November 2010, 13:57 GMT+2
That makes sense, thanks. For the sake of consistency, I've moved it all to the end.

   hotkey_bookmark.patch (1.6 KiB) 
 apps/onplay.c        |    3 +++
 apps/onplay.h        |    1 +
 apps/settings_list.c |    4 ++--
 3 files changed, 6 insertions(+), 2 deletions(-)

Comment by Bill Weber (tufur1) - Wednesday, 10 November 2010, 18:22 GMT+2
This works for me on a fuze v2. I was supprized to find this key function ( implemented as a long press on the wps key) lost in the move from 3.6 to 3.7.
Thank you!!!
Comment by Michael Gentry (Confuseling) - Friday, 12 November 2010, 14:08 GMT+2
Thanks for testing - I'm glad it works.

If you have any other bright ideas about things that would make a good extra hotkey option, I can't offer any guarantees I can work out how to do them (create bookmark, I suspect, is unusually simple), but I'll have a look...

http://forums.rockbox.org/index.php?topic=25682.0
Comment by Bill Weber (tufur1) - Saturday, 13 November 2010, 07:20 GMT+2
The thing I'm seeing now as I have used your patch for two days is I am getting a bookmark file one level above the directory of my audiobook/lecture directory for each individual audiobook/lecture I listen to. It does contain the multiple bookmarks I have made. Which is good. But under 3.6, I was able to forgo these extraneous files by setting my bookmarks to recent folder creation and unique bookmarks only.
I would like this multi-bookmark file made when I set the bookmarking to non-unique under bookmarking settings and it should be made in the directory of the audiobook/lecture I'm listening to.
Good work!!!
Comment by Marek Salaba (salaba) - Saturday, 15 January 2011, 14:08 GMT+2
It looks like a great feature, which will be integrated?
Salaba
Comment by Marek Salaba (salaba) - Sunday, 06 February 2011, 20:17 GMT+2
Please integrate this to release 3.8.

Loading...