Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11766 - Android: Better notification integration

Attached to Project: Rockbox
Opened by Thomas Martitz (kugel.) - Saturday, 20 November 2010, 19:11 GMT+2
Last edited by Thomas Martitz (kugel.) - Friday, 18 February 2011, 21:42 GMT+2
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Player Type Another
Severity Low
Priority Normal
Reported Version Release 3.6
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This adds track information to the notification system on android in to ways:
a) on track change, the notification on the bar announces the new track (<title> - <artist>)
b) when the notifications are expanded then it'll show the track information with title in bold, similarly to the built in media player.

IMO this both is done better than most existing media player apps (they don't a) at all and my b) looks more nicely)

The patch is quite big because it adds some kind of notification api. Do you think it's OK or too much?
   android-notification.diff (22.8 KiB) 
 b/android/res/layout/statusbar.xml                              |   60 +++++++++
 b/android/src/org/rockbox/Helper/RunForegroundManager.java      |   52 +++++--
 b/android/src/org/rockbox/RockboxService.java                   |   11 +
 b/apps/SOURCES                                                  |    1 
 b/apps/apps.make                                                |    3 
 b/apps/gui/wps.c                                                |    2 
 b/apps/hosted/notification.c                                    |   52 +++++++
 b/apps/hosted/notification.h                                    |   28 ++++
 b/apps/main.c                                                   |   10 +
 b/firmware/SOURCES                                              |    1 
 b/firmware/target/hosted/android/app/notification-application.c |   66 ++++++++++
 b/firmware/target/hosted/android/app/notification-target.h      |   31 ++++
 12 files changed, 294 insertions(+), 23 deletions(-)

This task depends upon

Closed by  Thomas Martitz (kugel.)
Friday, 18 February 2011, 21:42 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Committed without the notification API.

Loading...